Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(queue): use GetInfo for setup #509

Merged
merged 16 commits into from
Sep 25, 2023
Merged

feat(queue): use GetInfo for setup #509

merged 16 commits into from
Sep 25, 2023

Conversation

timhuynh94
Copy link
Contributor

@timhuynh94 timhuynh94 commented Sep 18, 2023 •
edited
Loading

Changes:

  • Use velaClient to request GetInfo for queue credentials

Depends on server #957

@timhuynh94 timhuynh94 changed the title Feat v21 queue registration feat (worker): v21 queue registration Sep 18, 2023
@timhuynh94 timhuynh94 marked this pull request as ready for review September 18, 2023 20:03
@timhuynh94 timhuynh94 requested a review from a team as a code owner September 18, 2023 20:03
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Merging #509 (6b9b8ea) into main (dd23185) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage   83.44%   83.44%           
=======================================
  Files          69       69           
  Lines        5381     5381           
=======================================
  Hits         4490     4490           
  Misses        746      746           
  Partials      145      145

@wass3rw3rk wass3rw3rk changed the title feat (worker): v21 queue registration feat(queue): use GetInfo for setup Sep 25, 2023
ecrupper
ecrupper requested changes Sep 25, 2023
View reviewed changes
cmd/vela-worker/operate.go Outdated Show resolved Hide resolved
cmd/vela-worker/operate.go Outdated Show resolved Hide resolved
cmd/vela-worker/operate.go Outdated Show resolved Hide resolved
cmd/vela-worker/operate.go Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Sep 25, 2023
View reviewed changes
cmd/vela-worker/operate.go Show resolved Hide resolved
cmd/vela-worker/operate.go Outdated Show resolved Hide resolved
cmd/vela-worker/operate.go Show resolved Hide resolved
@timhuynh94 timhuynh94 requested review from ecrupper and a team September 25, 2023 18:55
@timhuynh94 timhuynh94 merged commit de988b0 into main Sep 25, 2023
12 checks passed
@timhuynh94 timhuynh94 deleted the feat_v21_queue_registration branch September 25, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ecrupper ecrupper ecrupper approved these changes

@wass3rw3rk wass3rw3rk wass3rw3rk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timhuynh94 @wass3rw3rk @ecrupper