feat(worker): add worker registration #503

timhuynh94 · 2023-08-30T18:46:35Z

Changes:

functionally "group" SERVER_SECRET, QUEUE_PUBLIC_KEY and QUEUE_ADDRESS and treat them as a WorkerRegistration payload
if all 3 are passed to the worker in ENV then skip registration
if any are not provided, block until /register is hit
in api/register.go extract (1) token (2) pub key (3) queue address from the json body and pass it along through one channel that uses WorkerRegistration struct

Depends on #498 , #307

Co-authored-by: Renovate Bot <[email protected]>

Co-authored-by: Neal Coleman <[email protected]>

Co-authored-by: Renovate Bot <[email protected]>

Co-authored-by: Kelly Merrick <[email protected]>

* revert: stream container logs * feat: add flag to enable streaming logs * feat(executor): add logic to stream logs if enabled * enhance: make log publishing method configurable * enhance: use configurable log publishing method * chore: configure time log publish method for local * chore: address linter feedback * chore: fix tests for code changes * chore: address linter feedback v2

….2 (#237) Co-authored-by: Renovate Bot <[email protected]>

* enhance(version): add fallback for empty tag * enhance(version): use go version from runtime library * chore: clean go code

* StepFromContainer -> StepFromContainerEnvironment * Use library.StepFromBuildContainer to create new Steps * update go-vela/types * go mod tidy Co-authored-by: David May <[email protected]>

Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Jordan Brockopp <[email protected]>

Co-authored-by: Renovate Bot <[email protected]>

* initial changes * add some replace logic for secret masking * bringing in new types * fix go mod validate * multi line compatibility and initial testing work * added testing for internal secret masking * add back accidental deletion of error checking Co-authored-by: Jordan Brockopp <[email protected]>

Co-authored-by: Renovate Bot <[email protected]>

* update copyright year to 2022 * fix quotes

….0 (#259) Co-authored-by: Renovate Bot <[email protected]>

Co-authored-by: Renovate Bot <[email protected]>

…istration

codecov · 2023-09-06T21:07:20Z

Codecov Report

Merging #503 (92f1d04) into main (dd23185) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #503   +/-   ##
=======================================
  Coverage   83.44%   83.44%           
=======================================
  Files          69       69           
  Lines        5381     5381           
=======================================
  Hits         4490     4490           
  Misses        746      746           
  Partials      145      145

Files Changed	Coverage Δ
router/middleware/worker_registration.go	`100.00% <100.00%> (ø)`

github-actions · 2023-09-08T20:09:43Z

mock/worker/register.go

 	}

 	c.JSON(http.StatusOK, "successfully passed token to worker")
 }
+
+// validatePubKey is a helper function to validate
+// the provided pubkey


🚫 [golangci] _{reported by reviewdog 🐶}
Comment should end in a period (godot)

github-actions · 2023-09-08T20:09:43Z

mock/worker/register.go

+}
+
+// validateQueueAddress is a helper function to validate
+// the provided queue address


🚫 [golangci] _{reported by reviewdog 🐶}
Comment should end in a period (godot)

github-actions · 2023-09-08T20:09:43Z

api/register.go

@@ -127,3 +149,44 @@ func getSubjectFromToken(token string) (string, error) {

 	return sub, nil
 }
+
+// validatePubKey is a helper function to validate
+// the provided pubkey


🚫 [golangci] _{reported by reviewdog 🐶}
Comment should end in a period (godot)

github-actions · 2023-09-08T20:09:43Z

mock/worker/register.go

 //
 // Use of this source code is governed by the LICENSE file in this repository.

 package worker

 import (
+	"encoding/base64"
+	"fmt"
+	"github.com/go-vela/server/util"


🚫 [golangci] _{reported by reviewdog 🐶}
File is not goimports-ed (goimports)

github-actions · 2023-09-08T20:09:43Z

router/middleware/worker_registration_test.go

@@ -5,6 +5,7 @@
 package middleware

 import (
+	"github.com/go-vela/types/library"


🚫 [golangci] _{reported by reviewdog 🐶}
File is not goimports-ed (goimports)

github-actions · 2023-09-08T20:09:43Z

api/register.go

 	"fmt"
+	"github.com/go-vela/server/util"


🚫 [golangci] _{reported by reviewdog 🐶}
File is not goimports-ed (goimports)

github-actions · 2023-09-08T20:09:43Z

router/middleware/worker_registration_test.go

@@ -13,12 +14,13 @@ import (
 	"github.com/gin-gonic/gin"
 )

-func TestMiddleware_RegisterToken(t *testing.T) {
+func TestMiddleware_WorkerRegistration(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
unnecessary leading newline (whitespace)

github-actions · 2023-09-08T20:09:43Z

cmd/vela-worker/exec.go

@@ -45,7 +45,6 @@ func (w *Worker) exec(index int, config *library.Worker) error {
 	if err != nil {
 		return err
 	}
-
 	if item == nil {


🚫 [golangci] _{reported by reviewdog 🐶}
if statements should only be cuddled with assignments (wsl)

github-actions · 2023-09-08T20:09:43Z

cmd/vela-worker/operate.go

+	// once worker created/check in, queue details are used to setup queue here.
+	w.Config.Queue.Address = t.GetQueueAddress()
+	w.Config.Queue.PublicKey = t.GetPublicKey()
+	logrus.Trace("Validating queue details")


🚫 [golangci] _{reported by reviewdog 🐶}
only cuddled expressions if assigning variable or using from line above (wsl)

github-actions · 2023-09-08T20:09:43Z

cmd/vela-worker/operate.go

@@ -173,6 +191,7 @@ func (w *Worker) operate(ctx context.Context) error {
 					// (do not pass the context to avoid errors in one
 					// executor+build inadvertently canceling other builds)
 					//nolint:contextcheck // ignore passing context
+
 					err = w.exec(id, registryWorker)


🚫 [golangci] _{reported by reviewdog 🐶}
Function exec->exec$1 should pass the context parameter (contextcheck)

jbrockopp and others added 30 commits October 27, 2021 11:02

feat(runtime): add logic from pkg-runtime (#222)

69c1cca

fix(deps): update module github.com/docker/docker to v20.10.10 (#226)

7d5ab07

Co-authored-by: Renovate Bot <[email protected]>

refactor: update queue packge to get from server (#225)

fe2ebdf

Co-authored-by: Neal Coleman <[email protected]>

fix(deps): update deps (patch) (#227)

292fd57

Co-authored-by: Renovate Bot <[email protected]>

refactor: update compiler package to get from server (#228)

0f81aee

feat(mock): add logic from go-vela/mock (#229)

ce0770e

Co-authored-by: Kelly Merrick <[email protected]>

refactor: pull server mock package from server (#230)

b43e72a

chore: release v0.11.0-rc1 (#234)

ce4ff02

fix: compare time chunks against zero (#235)

a0a087f

chore: release v0.11.0-rc3 (#236)

3715d12

chore(v0.11.0): update dependencies for v0.11.0 (#238)

7f6f311

fix(deps): update module github.com/opencontainers/image-spec to v1.0…

b586ace

….2 (#237) Co-authored-by: Renovate Bot <[email protected]>

enhance: setting version information (#240)

11dd769

* enhance(version): add fallback for empty tag * enhance(version): use go version from runtime library * chore: clean go code

fix(deps): update deps (patch) to v0.22.4 (#241)

cdef8a6

fix: move Step init logic to library (#239)

3c1ba59

* StepFromContainer -> StepFromContainerEnvironment * Use library.StepFromBuildContainer to create new Steps * update go-vela/types * go mod tidy Co-authored-by: David May <[email protected]>

fix(deps): update module github.com/gin-gonic/gin to v1.7.6 (#242)

eb9aa93

Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Jordan Brockopp <[email protected]>

fix(deps): update module github.com/gin-gonic/gin to v1.7.7 (#243)

f7f6d55

Co-authored-by: Renovate Bot <[email protected]>

fix: local setup with server (#245)

7e36616

feat(logs): allow setting max log size (#244)

e15d698

chore: update go-vela/server dependency (#252)

140e526

enhance: use application logger (#246)

b848e1b

fix(docker): pulling images without output (#253)

21411a0

chore(deps): update go to 1.17 (#255)

0be642c

fix(deps): update kubernetes packages to v0.23.1 (#250)

30be024

fix(deps): update module gotest.tools/v3 to v3.1.0 (#256)

ab3d223

Co-authored-by: Renovate Bot <[email protected]>

chore: update copyright year to 2022 (#257)

a6ebe85

* update copyright year to 2022 * fix quotes

fix(deps): update module github.com/prometheus/client_golang to v1.12…

0696d69

….0 (#259) Co-authored-by: Renovate Bot <[email protected]>

fix(deps): update module github.com/google/go-cmp to v0.5.7 (#260)

d5b7de2

Co-authored-by: Renovate Bot <[email protected]>

plyr4 and others added 9 commits August 25, 2023 11:54

todo: build executables types change

45de442

Merge branch 'main' into feat/queue-signing

d329bd6

chore: go mod tidy

50ccf9b

support for in flight pubkey

925b2b8

fix comments

0d29f97

Merge branch 'main' into v21_q_creds_removal

be6e846

Merge latest

b063017

clean up

4ce8079

go mod tidy

cb1d8ff

timhuynh94 marked this pull request as ready for review August 30, 2023 21:08

timhuynh94 requested a review from a team as a code owner August 30, 2023 21:08

timhuynh94 added 4 commits September 1, 2023 11:19

workerregistration type

f2d3a24

fix conflicts

f3c425b

fix conflicts

2982053

remove reg token channel

1dc8f24

timhuynh94 changed the title ~~V21 queue registration~~ feat (worker): Add worker registration Sep 5, 2023

timhuynh94 added 3 commits September 5, 2023 15:17

combine both queue public key and queue creds removal into worker reg…

d06c26c

…istration

working registration

f167289

cleanup

389d8e1

wass3r changed the title ~~feat (worker): Add worker registration~~ feat(worker): add worker registration Sep 6, 2023

timhuynh94 added 2 commits September 6, 2023 14:07

make clean

82deb02

change to VELA_BUILD_EVENT

5bd9c4b

timhuynh94 added 3 commits September 6, 2023 16:21

change test func name

5cca93b

mock

49dfddd

add mock

7a921ab

github-actions bot reviewed Sep 8, 2023

View reviewed changes

timhuynh94 mentioned this pull request Sep 8, 2023

feat (cli): modify add/view worker go-vela/cli#479

Closed

Merge branch 'main' into v21_q_creds_removal

92f1d04

timhuynh94 closed this Sep 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(worker): add worker registration #503

feat(worker): add worker registration #503

timhuynh94 commented Aug 30, 2023 •

edited

Loading

codecov bot commented Sep 6, 2023 •

edited

Loading

github-actions bot Sep 8, 2023

github-actions bot Sep 8, 2023

github-actions bot Sep 8, 2023

github-actions bot Sep 8, 2023

github-actions bot Sep 8, 2023

github-actions bot Sep 8, 2023

github-actions bot Sep 8, 2023

github-actions bot Sep 8, 2023

github-actions bot Sep 8, 2023

github-actions bot Sep 8, 2023

feat(worker): add worker registration #503

feat(worker): add worker registration #503

Conversation

timhuynh94 commented Aug 30, 2023 • edited Loading

codecov bot commented Sep 6, 2023 • edited Loading

Codecov Report

github-actions bot Sep 8, 2023

Choose a reason for hiding this comment

github-actions bot Sep 8, 2023

Choose a reason for hiding this comment

github-actions bot Sep 8, 2023

Choose a reason for hiding this comment

github-actions bot Sep 8, 2023

Choose a reason for hiding this comment

github-actions bot Sep 8, 2023

Choose a reason for hiding this comment

github-actions bot Sep 8, 2023

Choose a reason for hiding this comment

github-actions bot Sep 8, 2023

Choose a reason for hiding this comment

github-actions bot Sep 8, 2023

Choose a reason for hiding this comment

github-actions bot Sep 8, 2023

Choose a reason for hiding this comment

github-actions bot Sep 8, 2023

Choose a reason for hiding this comment

timhuynh94 commented Aug 30, 2023 •

edited

Loading

codecov bot commented Sep 6, 2023 •

edited

Loading