feat(pipeline)!: add warnings to pipelines that use legacy YAML lib or have dupl anchors in map #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have dupl anchors in map
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -391,9 +391,9 @@ | |||
| } | |||
|
|
|||
| //nolint:lll // ignore long line length due to input arguments | |||
| func (c *client) mergeTemplate(bytes []byte, tmpl *yaml.Template, step *yaml.Step) (*yaml.Build, error) { | |||
| func (c *client) mergeTemplate(bytes []byte, tmpl *yaml.Template, step *yaml.Step) (*yaml.Build, []string, error) { | |||
| switch tmpl.Format { | |||
| case constants.PipelineTypeGo, "golang", "": | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
string golang has 3 occurrences, make it a constant (goconst)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1232 +/- ##
==========================================
+ Coverage 56.61% 56.66% +0.04%
==========================================
Files 626 626
Lines 35495 35541 +46
==========================================
+ Hits 20096 20139 +43
- Misses 14720 14722 +2
- Partials 679 680 +1
|
wass3rw3rk
requested changes
Dec 31, 2024
wass3rw3rk
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
warningsfield to pipelines that will aggregate non-breaking but call-out worthy YAML transgressions.