feat(repo)!: support allow_events struct #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
- Coverage 67.89% 67.79% -0.10%
==========================================
Files 318 318
Lines 13738 13754 +16
==========================================
- Hits 9327 9325 -2
- Misses 3944 3956 +12
- Partials 467 473 +6
|
wass3rw3rk
reviewed
Dec 11, 2023
wass3rw3rk
approved these changes
Dec 11, 2023
claire1618
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping all the legacy fields (
AllowPush,AllowPull,AllowTag,AllowDeploy,AllowComment) in order to preserve data for now with the intent of dropping the columns in a later release.Otherwise, all logic in the core path has been migrated to use the new
AllowEventsstruct in this PR. I also threw in the optionalVELA_DEFAULT_REPO_EVENTS_MASK, which allows admins to further customize those default events if they so choose.