Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: login redirect not working properly after component refactor #1044

Merged
merged 4 commits into from
Dec 31, 2024

Conversation

fmartingr
Copy link
Member

Bug introduced in #1017

The login component was not properly handling the dst parameter, and the backend was redirecting to the (now non-existant) /logjn route.

Modified the backend to properly redirect to / when the user is not authenticated and added dst parameter support to the login component.

@fmartingr fmartingr added this to the 1.7.3 milestone Dec 31, 2024
@fmartingr fmartingr self-assigned this Dec 31, 2024
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.35%. Comparing base (0b745c1) to head (61c700d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1044      +/-   ##
==========================================
+ Coverage   34.28%   34.35%   +0.07%     
==========================================
  Files          61       61              
  Lines        5393     5399       +6     
==========================================
+ Hits         1849     1855       +6     
  Misses       3320     3320              
  Partials      224      224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmartingr fmartingr merged commit e1e5828 into master Dec 31, 2024
17 checks passed
@fmartingr fmartingr deleted the fix/login-redirect branch December 31, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant