fix: webroot not working in archive view #1043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the base URL is required for the archived page to render properly when a
--webroot
is in use.I tested the use of the webroot by running a local nginx configured to be a reverse proxy (see configuration below) and then running shiori:
Prior to the fix my archived page looks like this:
And with the fix it looks like this:
I tested without
--webroot
and confirm that behavior still works.nginx config
I tested on MacOS by installing nginx
brew install nginx
and then editing/opt/homebrew/etc/nginx/nginx.conf
to look like:Fixes #1042