Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(kubernetes): add tmp volume #1040

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

hackeryarn
Copy link
Contributor

When trying to generate ebooks in a kubernetes hosted instance, I noticed a failure due to permissions in /tmp.

The best way to make sure that /tmp acts as expected, is to provide an emptyDir volume which will get cleaned up on container restart, which would be the expected behavior for a /tmp folder.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.28%. Comparing base (306487a) to head (d8a1e4f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1040   +/-   ##
=======================================
  Coverage   34.28%   34.28%           
=======================================
  Files          61       61           
  Lines        5393     5393           
=======================================
  Hits         1849     1849           
  Misses       3320     3320           
  Partials      224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmartingr
Copy link
Member

Thank you for fixing this part of the docs!

I used to have Shiori under kubernetes but went back to raw docker and then to LXC, so I miss all these issues since I can't test all configurations.

@fmartingr fmartingr merged commit 8be5775 into go-shiori:master Dec 31, 2024
12 checks passed
@hackeryarn
Copy link
Contributor Author

@fmartingr I'll be running Shiori under kubernetes for the foreseeable future. I'll try to keep an eye out for any kubernetes related issues that pop up, but also feel free to tag me if you need help looking into any of those issues.

@fmartingr
Copy link
Member

@fmartingr I'll be running Shiori under kubernetes for the foreseeable future. I'll try to keep an eye out for any kubernetes related issues that pop up, but also feel free to tag me if you need help looking into any of those issues.

Awesome, thank you. Likewise, let me know if there's something failing that I need to take a look into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants