Update docker-compose.yaml #1038
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed deprecated "links to" and changed to depends_on and setup a shiori network so each sub-package doesn't need an external network port.
fmartingr
requested changes
Dec 31, 2024
There was a problem hiding this comment.
Hey @noticons, thank you for taking some time to update the compose file. I've added a few comments below since this docker compose is not meant to be used to deploy Shiori but only for local development, please take a look at the comments and let me know if you have any questions.
Co-authored-by: Felipe Martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed deprecated "links to" and changed to depends_on and setup a shiori network so each sub-package doesn't need an external network port.