Represent GLsync as uintptr, not unsafe.Pointer #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go treats unsafe.Pointer as actual pointers, requiring them to be valid, and allowing them to keep Go memory referenced. GLsync, however, can be of arbitrary value, such as simple incrementing IDs, or values that look like – but aren't – Go memory. In order to avoid faulty garbage collection behaviour, these values must not be stored in unsafe.Pointer. Instead we use uintptr, which is guaranteed to be large enough to hold GLsync values. Closes go-gl/gl#71 Updates #63
|
LGTM, thanks! We should probably regenerate everything in go-gl/gl after this change. |
Yep. I'll reopen go-gl/gl#71 to track that. |
dmitshur
added a commit
to go-gl/gl
that referenced
this pull request
May 9, 2017
Regenerate all bindings after generator change in go-gl/glow#79. Done with latest version of glow: go generate -tags=gen github.com/go-gl/gl Resolves #71.
|
Should we revert this PR until we get to a resolution in go-gl/gl#71? glow is in a bad state now, and will block other changes (e.g., #80). |
|
Alas, yes. We can submit it again once we have a resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go treats unsafe.Pointer as actual pointers, requiring them to be valid,
and allowing them to keep Go memory referenced.
GLsync, however, can be of arbitrary value, such as simple incrementing
IDs, or values that look like – but aren't – Go memory.
In order to avoid faulty garbage collection behaviour, these values must
not be stored in unsafe.Pointer. Instead we use uintptr, which is
guaranteed to be large enough to hold GLsync values.
Closes go-gl/gl#71
Updates #63