Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pure Go SQLite3 #32628

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Pure Go SQLite3 #32628

wants to merge 1 commit into from
+35 −6

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 24, 2024 •
edited
Loading

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 24, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 24, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/dependencies labels Nov 24, 2024
@wxiaoguang wxiaoguang marked this pull request as draft November 24, 2024 07:25
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 24, 2024
@wxiaoguang wxiaoguang force-pushed the refactor-go-sqlite3 branch 2 times, most recently from 3e6f93d to cee4249 Compare November 24, 2024 09:45
@wxiaoguang wxiaoguang marked this pull request as ready for review November 24, 2024 10:03
@lunny
Copy link
Member

lunny commented Nov 24, 2024 •
edited
Loading

It seems all tests for sqlite PASSed and it took about 18m which is almost the same as the cgo sqlite driver. But the library is very young.

Maybe we can have a build tag for the change first.

@6543
Copy link
Member

6543 commented Nov 26, 2024

Maybe we can have a build tag for the change first.

I'm also looking forward to this but wana have it behind a tag to have both options ...

@wxiaoguang
Copy link
Contributor Author

Feel free to edit this PR directly, I was just proposing a demo and I might not have enough time on it.

@wxiaoguang wxiaoguang marked this pull request as draft November 26, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/dependencies modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @6543 @GiteaBot