Enable more golangci linters #219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obbardc
changed the title
obbardc
force-pushed
the
wip/obbardc/enable-all-linters
branch
from
8c49b76 to
dd55d94
Compare
Fix the mistakes found by the misspell linter: backend_qemu.go:55:56: `usefull` is a misspelling of `useful` (misspell) /* The default cpu is a 32 bit one, which isn't very usefull ^ machine.go:243:39: `especialy` is a misspelling of `especially` (misspell) // Mounts for java VM configuration, especialy security policies ^ Signed-off-by: Christopher Obbard <[email protected]>
Fix the mistakes found by the revive linter:
cmd/fakemachine/main.go:149:10: superfluous-else: if block ends with call to os.Exit function, so drop this else and outdent its block (revive)
} else {
os.Exit(1)
}
decompressors_test.go:42:3: increment-decrement: should replace i += 1 with i++ (revive)
i += 1
^
backend_qemu.go:178:38: unused-parameter: parameter 'mount' seems to be unused, consider removing or renaming it as _ (revive)
func (b qemuBackend) MountParameters(mount mountPoint) (string, []string) {
^
machine.go:569:3: increment-decrement: should replace i += 1 with i++ (revive)
i += 1
^
Signed-off-by: Christopher Obbard <[email protected]>
These linters seem to be useful. Enable them. Signed-off-by: Christopher Obbard <[email protected]>
sjoerdsimons
force-pushed
the
wip/obbardc/enable-all-linters
branch
from
dd55d94 to
2faab3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.