Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract eslint config #496

Merged
merged 10 commits into from
Jan 9, 2025
Merged

Conversation

frontendphil
Copy link
Member

Part of #469

Since the number of applications and packages is increasing it becomes much harder to keep the general linting setup in sync. I've extracted the base rules into a shared config that can be extended as needed by each package/application.

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-pilot-example-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 11:18am

Copy link

cloudflare-workers-and-pages bot commented Jan 9, 2025

Deploying zodiac-pilot-connect with  Cloudflare Pages  Cloudflare Pages

Latest commit: 32a1d2b
Status: ✅  Deploy successful!
Preview URL: https://6c50cf31.zodiac-pilot.pages.dev
Branch Preview URL: https://chore-extract-eslint-config.zodiac-pilot.pages.dev

View logs

Copy link

github-actions bot commented Jan 9, 2025

Coverage Report for deployables/extension

Status Category Percentage Covered / Total
🔵 Lines 62.38% 4777 / 7657
🔵 Statements 62.38% 4777 / 7657
🔵 Functions 69.21% 272 / 393
🔵 Branches 79.6% 734 / 922
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
deployables/extension/src/panel/integrations/safe/signing.ts 32.6% 100% 0% 32.6% 23-29, 34-37, 40-50, 53, 56-65
Generated in workflow #530 for commit 32a1d2b by the Vitest Coverage Report Action

@frontendphil frontendphil enabled auto-merge (squash) January 9, 2025 11:10
Copy link

cloudflare-workers-and-pages bot commented Jan 9, 2025

Deploying zodiac-pilot with  Cloudflare Pages  Cloudflare Pages

Latest commit: 32a1d2b
Status: ✅  Deploy successful!
Preview URL: https://4a760fe7.zodiac-pilot-29m.pages.dev
Branch Preview URL: https://chore-extract-eslint-config.zodiac-pilot-29m.pages.dev

View logs

@frontendphil frontendphil force-pushed the chore/extract-eslint-config branch from 766cac3 to 32a1d2b Compare January 9, 2025 11:14
@frontendphil frontendphil merged commit e36819e into main Jan 9, 2025
16 checks passed
@frontendphil frontendphil deleted the chore/extract-eslint-config branch January 9, 2025 11:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant