chore(deps): update dependency ser-kit to v1 #321

renovate · 2024-12-11T12:06:28Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
ser-kit	`^0.3.17` -> `^1.0.0`

Release Notes

gnosisguild/ser-kit (ser-kit)

`v1.0.0`

Compare Source

⚠ BREAKING CHANGES

reorganized package exports

Features

Planning and Execution for foundation route topologies (#3) (4756138)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

vercel · 2024-12-11T12:06:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
zodiac-pilot-example-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 11, 2024 4:42pm

cloudflare-workers-and-pages · 2024-12-11T12:07:04Z

Deploying zodiac-pilot with Cloudflare Pages

Latest commit:	`7c6f91c`
Status:	✅ Deploy successful!
Preview URL:	https://64fd7be1.zodiac-pilot-29m.pages.dev
Branch Preview URL:	https://renovate-ser-kit-1-x.zodiac-pilot-29m.pages.dev

View logs

github-actions · 2024-12-11T12:07:22Z

Coverage Report for extension

Status	Category	Percentage	Covered / Total
🔵	Lines	60.89%	4965 / 8154
🔵	Statements	60.89%	4965 / 8154
🔵	Functions	66.59%	295 / 443
🔵	Branches	77.5%	734 / 947

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
extension/src/types.ts	100%	100%	100%	100%
extension/src/chains/getChainId.ts	100%	100%	100%	100%
extension/src/panel/execution-routes/useRouteConnect.ts	80%	85%	100%	80%	18-27, 52, 74-75
extension/src/panel/integrations/safe/signing.ts	32.6%	100%	0%	32.6%	23-29, 33-36, 39-49, 52, 55-64
extension/src/panel/integrations/zodiac/useZodiacModules.ts	50.41%	78.57%	66.66%	50.41%	71-72, 86-154, 157-161
extension/src/panel/pages/Root.tsx	0%	0%	0%	0%	1-49
extension/src/panel/pages/legacyConnectionMigrations.ts	88.66%	87.75%	100%	88.66%	29, 48-59, 79, 131, 138-139, 173
extension/src/panel/pages/routes/edit.$routeId/useConnectionDryRun.tsx	16.98%	28.57%	25%	16.98%	30-33, 35-59, 66-88, 91-152
extension/src/panel/pages/routes/edit.$routeId/wrapRequest.ts	12.72%	100%	0%	12.72%	13-62
extension/src/panel/pages/routes/edit.$routeId/wallet/ConnectWallet.tsx	72.46%	90%	60%	72.46%	46-50, 57-61, 81-89
extension/src/panel/pages/transactions/RolePermissionCheck.tsx	19.51%	100%	0%	19.51%	26-80, 88-162
extension/src/panel/pages/transactions/Submit.tsx	17.36%	33.33%	20%	17.36%	40-41, 44-144, 149-155, 167-172, 185-211
extension/src/panel/pages/transactions/Transaction.tsx	91.66%	41.66%	83.33%	91.66%	57, 100, 105-107, 116, 148-152
extension/src/panel/providers/isConnected.ts	100%	100%	100%	100%
extension/src/panel/providers-ui/ProvideProvider.tsx	44.78%	41.66%	66.66%	44.78%	38-39, 42, 53-70, 76-124, 130-139, 197-214
extension/src/panel/providers-ui/SubmitTransactionContext.tsx	36%	100%	100%	36%	32-70
extension/src/panel/providers/fork-provider/ForkProvider.ts	21.62%	77.77%	38.46%	21.62%	85-180, 193-218, 221-287, 290-324, 342-343, 348-373, 396-440
extension/src/panel/providers/fork-provider/translateSignSnapshotVote.ts	18.18%	100%	0%	18.18%	21-62
extension/src/panel/state/actions.ts	0%	0%	0%	0%	1-3
extension/src/panel/state/reducer.ts	4.87%	100%	0%	4.87%	16-59
extension/src/panel/transactionTranslations/applicableTranslationCache.ts	100%	100%	100%	100%
extension/src/panel/transactionTranslations/cowswapSetPreSignature.ts	46.98%	33.33%	100%	46.98%	44-45, 54-101
extension/src/panel/transactionTranslations/types.ts	100%	100%	100%	100%
extension/src/panel/transactionTranslations/uniswapMulticall.ts	86.48%	33.33%	100%	86.48%	22-23, 27-28, 48
extension/src/panel/transactionTranslations/useApplicableTranslation.ts	67.82%	63.15%	85.71%	67.82%	35-61, 78, 90-95, 107-108, 119-126
extension/src/panel/transactionTranslations/useGloballyApplicableTranslation.ts	52.1%	70.58%	83.33%	52.1%	29-71, 84-85, 91-95, 114-115, 129-135, 151-157
extension/src/panel/transactionTranslations/karpatkeyInstitutional/bridges.test.ts	100%	100%	100%	100%
extension/src/panel/transactionTranslations/karpatkeyInstitutional/bridges.ts	99.3%	75%	100%	99.3%	21-22
extension/src/panel/transactionTranslations/karpatkeyInstitutional/kpkBridgeAware.test.ts	100%	100%	100%	100%
extension/src/panel/transactionTranslations/karpatkeyInstitutional/kpkBridgeAware.ts	95.4%	85.71%	100%	95.4%	70-71, 80-81

Generated in workflow #37 for commit 7c6f91c by the Vitest Coverage Report Action

cloudflare-workers-and-pages · 2024-12-11T12:07:32Z

Deploying zodiac-pilot-connect with Cloudflare Pages

Latest commit:	`7c6f91c`
Status:	✅ Deploy successful!
Preview URL:	https://fcf48531.zodiac-pilot.pages.dev
Branch Preview URL:	https://renovate-ser-kit-1-x.zodiac-pilot.pages.dev

View logs

frontendphil · 2024-12-11T12:47:17Z

@cristovaoth, I would appreciate it if you could have a quick look over the changes in this PR. I think I adjusted everything the right way. However, I'm mostly unsure about the parsePrefixedAddress migration. It seems like the v1 version only returns the parsed address, and to also get the chainId, I now need to use splitPrefiexedAddress, but I'm not 100% sure.

The description states options are optional but the way the method was currently typed they would be required. I've also adjusted the `package.json` slightly to define exports for all kinds of bundlers (e.g. the top-level `module` field was missing). AFAICT there are some issues with resolving stuff (at least based on my update PR). Relates to gnosisguild/zodiac-pilot#321

renovate · 2024-12-11T13:00:19Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

jfschwarz · 2024-12-11T16:32:37Z

extension/src/panel/pages/legacyConnectionMigrations.ts

@@ -46,33 +47,33 @@ export function fromLegacyConnection(
  const delayModuleWaypoint = moduleType === KnownContracts.DELAY && {
    account: {
      type: AccountType.DELAY,
-      prefixedAddress: modulePrefixedAddress,
+      prefixedAddress: modulePrefixedAddress?.toLowerCase(),


@cristovaoth looking at this, it seems a bit awkward that ser-kit generally operates on lowercase prefixed addresses, but its formatPrefixedAddress produces a checksummed version.

jfschwarz

code looks good

frontendphil · 2024-12-11T16:39:59Z

LFG 🚀

vercel bot deployed to Preview December 11, 2024 12:07 View deployment

renovate bot force-pushed the renovate/ser-kit-1.x branch from 51217c1 to ab2e360 Compare December 11, 2024 12:14

vercel bot deployed to Preview December 11, 2024 12:16 View deployment

renovate bot force-pushed the renovate/ser-kit-1.x branch from ab2e360 to 968dd0a Compare December 11, 2024 12:17

vercel bot deployed to Preview December 11, 2024 12:19 View deployment

renovate bot force-pushed the renovate/ser-kit-1.x branch from 968dd0a to fc73c1c Compare December 11, 2024 12:23

vercel bot deployed to Preview December 11, 2024 12:26 View deployment

renovate bot force-pushed the renovate/ser-kit-1.x branch from fc73c1c to 2bf8861 Compare December 11, 2024 12:28

vercel bot deployed to Preview December 11, 2024 12:30 View deployment

renovate bot force-pushed the renovate/ser-kit-1.x branch from 2bf8861 to c2f1ee3 Compare December 11, 2024 12:34

vercel bot deployed to Preview December 11, 2024 12:35 View deployment

vercel bot deployed to Preview December 11, 2024 12:39 View deployment

frontendphil mentioned this pull request Dec 11, 2024

fix: make options for planExecution really optional gnosisguild/ser-kit#6

Merged

frontendphil requested a review from cristovaoth December 11, 2024 12:45

vercel bot deployed to Preview December 11, 2024 12:46 View deployment

cristovaoth approved these changes Dec 11, 2024

View reviewed changes

vercel bot deployed to Preview December 11, 2024 13:42 View deployment

frontendphil force-pushed the renovate/ser-kit-1.x branch from 05862c3 to a34f2e8 Compare December 11, 2024 14:38

vercel bot deployed to Preview December 11, 2024 14:40 View deployment

vercel bot deployed to Preview December 11, 2024 14:44 View deployment

frontendphil requested a review from jfschwarz December 11, 2024 16:25

vercel bot deployed to Preview December 11, 2024 16:26 View deployment

jfschwarz reviewed Dec 11, 2024

View reviewed changes

vercel bot deployed to Preview December 11, 2024 16:34 View deployment

jfschwarz approved these changes Dec 11, 2024

View reviewed changes

renovate bot and others added 12 commits December 11, 2024 17:36

chore(deps): update dependency ser-kit to v1

c1ca01e

update to ser-kit v1

356cbbd

more adjustments around parsePrefixedAddress

6069155

use PROPOSE_TRANSACTION instead of PROPOSE_SAFE_TRANSACTION

c2a8901

chore: replace MetaTransactionData type with MetaTransactionRequest

70169f5

update ser-kit to v1.0.2

ef9f1f2

migrate some tests

6ed4c2b

update another place to use metaTransactionRequest

100305e

update ser-kit to v1.0.3

6db1a9c

handle transition from bigint to string

c9618f4

fix type issue

c495d21

remove deprecated dependency

7c6f91c

frontendphil force-pushed the renovate/ser-kit-1.x branch from 3f4c38c to 7c6f91c Compare December 11, 2024 16:36

frontendphil enabled auto-merge (squash) December 11, 2024 16:37

vercel bot deployed to Preview December 11, 2024 16:42 View deployment

frontendphil merged commit 2f1544e into main Dec 11, 2024
12 checks passed

frontendphil deleted the renovate/ser-kit-1.x branch December 11, 2024 16:44

github-actions bot locked and limited conversation to collaborators Dec 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update dependency ser-kit to v1 #321

chore(deps): update dependency ser-kit to v1 #321

renovate bot commented Dec 11, 2024

vercel bot commented Dec 11, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 11, 2024 •

edited

Loading

frontendphil commented Dec 11, 2024

renovate bot commented Dec 11, 2024

jfschwarz Dec 11, 2024

jfschwarz left a comment

frontendphil commented Dec 11, 2024

chore(deps): update dependency ser-kit to v1 #321

chore(deps): update dependency ser-kit to v1 #321

Conversation

renovate bot commented Dec 11, 2024

Release Notes

v1.0.0

⚠ BREAKING CHANGES

Features

Configuration

vercel bot commented Dec 11, 2024 • edited Loading

cloudflare-workers-and-pages bot commented Dec 11, 2024 • edited Loading

Deploying zodiac-pilot with Cloudflare Pages

github-actions bot commented Dec 11, 2024 • edited Loading

Coverage Report for extension

cloudflare-workers-and-pages bot commented Dec 11, 2024 • edited Loading

Deploying zodiac-pilot-connect with Cloudflare Pages

frontendphil commented Dec 11, 2024

renovate bot commented Dec 11, 2024

Edited/Blocked Notification

jfschwarz Dec 11, 2024

Choose a reason for hiding this comment

jfschwarz left a comment

Choose a reason for hiding this comment

frontendphil commented Dec 11, 2024

`v1.0.0`

vercel bot commented Dec 11, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 11, 2024 •

edited

Loading