Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multistage to reduce test image size #187

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

hmzakhalid
Copy link
Member

@hmzakhalid hmzakhalid commented Nov 27, 2024

Uses a multistage build to reduce the Docker image size from 3.5 GB to 100 MB for #184 .
I also noticed that it was creating three separate images for the same build because each service in the Docker Compose file had its own build context. Instead, only one image should be built and shared across all the services, with each service simply instantiating its own container from that shared image.

Building the image first and then referencing it in the services resolves this issue.

Copy link
Contributor

coderabbitai bot commented Nov 27, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hmzakhalid hmzakhalid mentioned this pull request Nov 27, 2024
5 tasks
@ryardley ryardley merged commit 7258206 into mc/feat/add-kad-p2p-setup Nov 28, 2024
3 checks passed
ryardley added a commit that referenced this pull request Nov 28, 2024
* feat: remove rendevous + add initial kad setup

* Fix up whitespace

* Comment out unused constants

* Use mdns and kademlia to get integration test working

* Remove tcp as tests pass

* Add test for networking layer

* Add net test

* Revert folder rename

* Add comment

* Formatting

* Remove expect

* Remove constants

* Formatting

* Test docs

* Plumb config to dial peers

* Fix formating

* Extract matching function

* Refactor NetworkPeer

* Rename file

* Rename P2p -> NetworkRelay

* Rename p2p -> net

* Formatting

* Remove expect

* Remove expect

* Don't use privelaged

* Tidy code

* Use multistage to reduce test image size (#187)

---------

Co-authored-by: chad <[email protected]>
Co-authored-by: Hamza Khalid <[email protected]>
@hmzakhalid hmzakhalid deleted the hmza/update-dockerfile branch December 11, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants