-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use multistage to reduce test image size #187
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
* feat: remove rendevous + add initial kad setup * Fix up whitespace * Comment out unused constants * Use mdns and kademlia to get integration test working * Remove tcp as tests pass * Add test for networking layer * Add net test * Revert folder rename * Add comment * Formatting * Remove expect * Remove constants * Formatting * Test docs * Plumb config to dial peers * Fix formating * Extract matching function * Refactor NetworkPeer * Rename file * Rename P2p -> NetworkRelay * Rename p2p -> net * Formatting * Remove expect * Remove expect * Don't use privelaged * Tidy code * Use multistage to reduce test image size (#187) --------- Co-authored-by: chad <[email protected]> Co-authored-by: Hamza Khalid <[email protected]>
Uses a multistage build to reduce the Docker image size from 3.5 GB to 100 MB for #184 .
I also noticed that it was creating three separate images for the same build because each service in the Docker Compose file had its own build context. Instead, only one image should be built and shared across all the services, with each service simply instantiating its own container from that shared image.
Building the image first and then referencing it in the services resolves this issue.