Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Crisp Contracts and Move Compute Provider to Enclave #24

Merged
merged 12 commits into from
Dec 10, 2024

Conversation

hmzakhalid
Copy link
Member

@hmzakhalid hmzakhalid commented Nov 26, 2024

Pull Request Description -

This pull request description was automatically generated based on the information provided by the author .

Changes Introduced

  1. Merged evm_base Contract into the Risc0 CRISP Contract:

    • The evm_base contract has been merged into the Risc0 CRISP Contract as it was a small contract and currently unnecessary for the project.
    • Maintaining a separate contract added extra complexity to the repository without significant benefits.
    • With the existing enclave package in place, a common contract was redundant.
  2. Moved Compute Provider to the enclave Package:


Reasoning for Changes

  • Simplifies the repository by reducing the number of independent contracts.
  • Avoids premature optimization or over-engineering by eliminating unnecessary abstractions.
  • Centralizes related functionality within the enclave package, aligning with the overall design philosophy.

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
crisp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 3:20pm

Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hmzakhalid hmzakhalid merged commit 6f00968 into main Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants