Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - not let rewards contract call fail if the rewards contract hasn't been deployed #38

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

debjit-bw
Copy link
Member

@debjit-bw debjit-bw commented Dec 5, 2024

skips reward contract call instead of failing. this is in regards to maintaining consistency with other clients who also don't fail if the called contract code is null.

@debjit-bw debjit-bw marked this pull request as ready for review December 5, 2024 06:56
@debjit-bw debjit-bw changed the title consistent client behaviour fix - not let rewards contract call fail if the rewards contract hasn't been deployed Dec 5, 2024
@debjit-bw debjit-bw requested a review from dapplion December 5, 2024 07:07
@debjit-bw debjit-bw merged commit cdf984c into master Dec 5, 2024
6 checks passed
@debjit-bw debjit-bw deleted the client-consistency branch December 5, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants