Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Updates to Guide/Teku #291

Closed
wants to merge 6 commits into from
Closed

Small Updates to Guide/Teku #291

wants to merge 6 commits into from

Conversation

CVJoint
Copy link
Contributor

@CVJoint CVJoint commented Dec 2, 2022 •
edited
Loading

What

  • Fixed typo in Teku docs (Lodestar --> Teku)
  • Fixed checkpoint sync URL for Teku
  • Added comment on Teku permissions and why I recommend to change the user in the compose file
  • Removed JWT secret creation from Configure Server section (this is addressed during EL setup)
  • Changed folder structure in the JWT partial to align with docs for potential future use

@alebanzas
Copy link
Contributor

Thanks @CVJoint !

The text in the PR is a template to be filled.

Can you specify in the PR description the changes and reasons?

@alebanzas alebanzas added do not merge Code not ready to be merged documentation Improvements or additions to documentation labels Dec 2, 2022
@alebanzas
Copy link
Contributor

  • Removed JWT secret creation from Configure Server section (this is addressed during EL setup)

The JWT secret should be part of Step 1. Configure Server and not EL setup

@alebanzas
Copy link
Contributor

  • Changed folder structure in the JWT partial to align with docs for potential future use

This change breaks the Interactive Guide folder structure.

@alebanzas alebanzas mentioned this pull request Feb 8, 2023
Merged
@alebanzas
Copy link
Contributor

Closing in favor of: #384

@alebanzas alebanzas closed this Feb 8, 2023
@alebanzas alebanzas deleted the guide_updates branch February 8, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge Code not ready to be merged documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CVJoint @alebanzas