Make it build using OpenSSL 1.1.0 #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1175,8 +1175,7 @@ ngx_http_upstream_fair_set_session(ngx_peer_connection_t *pc, void *data) | |||
| rc = ngx_ssl_set_session(pc->connection, ssl_session); | |||
|
|
|||
| ngx_log_debug2(NGX_LOG_DEBUG_HTTP, pc->log, 0, | |||
| "set session: %p:%d", | |||
| ssl_session, ssl_session ? ssl_session->references : 0); | |||
| "set session: %p", ssl_session); | |||
There was a problem hiding this comment.
Hello @kroeckx ,
you should also use ngx_log_debug1(), the number denotes the number of arguments.
The reference counter is now internal in OpenSSL and not accessible any more.
wmfgerrit
pushed a commit
to wikimedia/operations-software-nginx
that referenced
this pull request
Sep 20, 2016
slact
pushed a commit
to slact/nginx-deb
that referenced
this pull request
Nov 29, 2016
joglomedia
added a commit
to joglomedia/nginx-upstream-fair
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference counter is now internal in OpenSSL and not accessible any more.