Added the support for AWS EventBridge Shopify Webhook

[veed76]

There is support for webhookSubscriptionCreate. I check in osiste/Laravel Package and there is no support for eventBridgeWebhookSubscriptionCreate GraphQL.

So I have added the support for eventBridgeWebhookSubscriptionCreate

Issue: #1113

[Kyon147]

Great PR but some minor feedback.

[veed76]

Hi @Kyon147
Can you please review the changes and merge it ASAP, so I can use this in the new version.

Thanks.

[Kyon147]

@veed76 - can you take a look at your code coverage as it has dropped a lot 80% down from 92.70%

[veed76]

@Kyon147 Can you please tell me next what I need to do?

[shota]

@veed76
Amazing PR. This is really what we want! However, checking address type with webhook_address_type configuration variable sometimes have another problem when some user want to mix EventBridge and REST webhook handling.

How about checking webhook URL like below?

src/Services/ApiHelper.php line 370

if ($addressType === 'arn') {

To new one like ...

if (str_starts_with($payload['address'], 'arn:')) {

This implementation is much more like old version which support EventBridge URL.

[gnikyt]

Hi @veed76
Essentially you need to edit the existing tests for ApiHelper, to ensure if someone changed the config, then the proper code is called.