Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: fqdn value for assetname support option #538

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

g-bougard
Copy link
Member

As pointed out in Changes file:

* Feature: Update support assetname-support as option for agent on most unix
  if 1 (the default), the short hostname is used as asset name
  if 2, the as-is hostname (can be fqdn) is used as asset name
  if 3, the fqdn hostname is used as asset name
  this feature does not apply on MacOS or Windows
  this feature now works for remote ssh and for option 3, it requires perl installed
  on targeted computer and perl mode enabled on defined remote.
* Feature: Make assetname-support option also works to compute agent deviceid when
  unknown

IMHO this is a better answer than forcing every one to use fqdn as proposed in #535.

It also makes the option working for remoteinventory task.

@g-bougard
Copy link
Member Author

Hi @po1vo

can you take a look to this PR as replacement candidate to #535 ?

@g-bougard
Copy link
Member Author

g-bougard commented Nov 23, 2023

As a side note, I udpated documentation to include assetname-support and reflect this PR:
https://glpi-agent.readthedocs.io/en/latest/configuration.html#assetname-support

@po1vo
Copy link
Contributor

po1vo commented Nov 23, 2023

can you take a look to this PR as replacement candidate to #535 ?

Looks good! Thanks.

@g-bougard g-bougard merged commit 67fcd2e into develop Nov 24, 2023
32 checks passed
@g-bougard g-bougard deleted the feature/fqdn-value-for-assetname-support-option branch November 24, 2023 14:54
@g-bougard g-bougard mentioned this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants