-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SentinelOne for Linux support #531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @MarcSamD
thank you for your pull request.
I see a little improvement to achieve on the _getSentineloneInfo()
API definition. Better use my second comment there if it's okay for you.
I saw you mixed tabulations and spaces for indentation. This is not a big deal with perl but keep using spaces for this project.
Finally, have you some output samples I can use to create a unittest ?
Code optimization by Guillaume Co-authored-by: Guillaume Bougard <[email protected]>
Hi @g-bougard , Below output sample of the 4 commands:
|
Hi @MarcSamD don't worry about your coding level, we are here to help finalize stuffs. Contributors with nice ideas will always be welcome. But I still thank you for this nice still working PR, and thank you for the sample output sharing, I'll be able to add a test with it. |
No description provided.