Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SentinelOne for Linux support #531

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

MarcSamD
Copy link
Contributor

No description provided.

Copy link
Member

@g-bougard g-bougard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @MarcSamD

thank you for your pull request.

I see a little improvement to achieve on the _getSentineloneInfo() API definition. Better use my second comment there if it's okay for you.

I saw you mixed tabulations and spaces for indentation. This is not a big deal with perl but keep using spaces for this project.

Finally, have you some output samples I can use to create a unittest ?

MarcSamD and others added 2 commits November 17, 2023 17:46
Code optimization by Guillaume

Co-authored-by: Guillaume Bougard <[email protected]>
@MarcSamD
Copy link
Contributor Author

Hi @g-bougard ,
Thank you for looking at this PR. I have very little knowledge in development so forgive me for submitting such a messy code.

Below output sample of the 4 commands:

Agent version: 30.1.1.10
SentinelCTL version: 30.1.1.10
Ranger version: 30.5.5.9
Git hash: 123456789abcde123456789abcde
DFI engine                          Enabled
DFI library                         Initialized
DFI library version                 30.5.6.5
DFI library git hash                d3dfc2a1641635f8e319257ab2314887fd0bc62d-Release.x64
Dynamic engine                      Enabled
Application control (container)     Disabled
Application control (host)          Disabled
Agent state      Enabled

Process Name     PID
orchestrator     901
network          902
scanner          903
agent            904
firewall         905
Anti Tamper                      On
AppInventory force update        86400
AppInventory interval            600
Connect through                  direct
Connectivity                     On
Customer id                      undefined
Device type                      server
Machine information interval     600
Override DV proxy address        undefined
Proxy address                    undefined
Secured protocol mode            best_effort
Site-Key                         12345abcdef6789
URL                              https://server-101.sentinelone.net
UUID                             123a123-12d12-1234-ab0c-1234bd1234

@g-bougard
Copy link
Member

Hi @MarcSamD

don't worry about your coding level, we are here to help finalize stuffs. Contributors with nice ideas will always be welcome.

But I still thank you for this nice still working PR, and thank you for the sample output sharing, I'll be able to add a test with it.

@g-bougard g-bougard merged commit 911e454 into glpi-project:develop Nov 20, 2023
16 checks passed
g-bougard added a commit that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants