RMS_MGMT

[yes1n]

#495 I did a pull request for now because it works but needs improvement. Added rms.t and rms.reg for the test.

[g-bougard]

Hi @yes1n
thank you for your PR, anyway I expected to still updated it following the few suggestions I made in the #495 discussion.

[yes1n]

I'm checking RMS.pm. Doesn't work yet, don't merge yet

[g-bougard]

Hi @yes1n
there's still not resolved comments. Can you check them ?

1. to fix logger not used when calling getRegistryValue()
2. your registry file needs to be renamed

[yes1n]

Hi, @g-bougard

1. Regarding the logger, please suggest a change, I will make it. I don't know how to do it
2. Registry file renamed in 7d6759a

[g-bougard]

Hi, @g-bougard

1. Regarding the logger, please suggest a change, I will make it. I don't know how to do it

2. Registry file renamed in [7d6759a](https://github.com/glpi-project/glpi-agent/pull/499/commits/7d6759ac4c91c2b3300f01338380d91ef1b767ca)

Please read my pending comments from yesterday where you have the suggestion (%params support in _getID()) and an explanation on why the registry filename is still not the right.

[g-bougard]

Hi @yes1n

my apologies, it seems I missed to validate the comment I was talking about.

Anyway, I found also another little issue in isEnabled() function.

Can you can know my requests ?

[yes1n]

@g-bougard, many thanks for your help. Applied your changes and renamed the file to rms-7.0.0.1-Parameters.reg

[g-bougard]

Hi @yes1n

there's a last critical problem with the test as it fails.
Investigating, I found you just have to remove the 3 following lines from your registry file as they are not expected by the mocking API:

[HKEY_LOCAL_MACHINE\SOFTWARE\Usoris]

[HKEY_LOCAL_MACHINE\SOFTWARE\Usoris\Remote Utilities Host]

[HKEY_LOCAL_MACHINE\SOFTWARE\Usoris\Remote Utilities Host\Host]

So the beginning of the file must look like:

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Usoris\Remote Utilities Host\Host\Parameters]

There also a not critical mistake (my fault) in the test file, check my comment.

[yes1n]

Hi @yes1n

there's a last critical problem with the test as it fails. Investigating, I found you just have to remove the 3 following lines from your registry file as they are not expected by the mocking API:

[HKEY_LOCAL_MACHINE\SOFTWARE\Usoris]

[HKEY_LOCAL_MACHINE\SOFTWARE\Usoris\Remote Utilities Host]

[HKEY_LOCAL_MACHINE\SOFTWARE\Usoris\Remote Utilities Host\Host]

So the beginning of the file must look like:

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Usoris\Remote Utilities Host\Host\Parameters]

ok, I'll do it in a couple of hours

[g-bougard]

Hi @yes1n
sorry, the AUTHOR tests failed again. This time on remaining spaces on a line that should remain empty.
After that, your PR should be fine for merging.

[yes1n]

@g-bougard Thank you for approving the idea and helping me write food. I would even say that you did almost everything. I even thought about learning Perl.