Drop support for Python 3.7 #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update tox builds to not list 3.7 - Update the "mindeps" tox build from 3.7 to 3.8 (both the test run and the `freezedeps` factor for "mindeps") - Remove a special constraint on `pip` version in the `freezedeps` build for 3.7-only - Update the minimum python version in package data to 3.8 and remove the 3.7 classifier - Update CI builds to de-list 3.7 and use 3.8 for the "mindeps" build - Remove some 3.6 and 3.7 compatibility code from the testsuite - Run `tox r -m freezedeps` to re-freeze all dependencies
- Apply TypedDict to both the mainline and experimental variants to declare the expected/required fields for valid data more explicitly - Expand the error checking in both of these variants to match the data loaded against the declared TypedDict invariants This changeset was blocked on the removal of py3.7 and is noted in existing comments as requiring 3.8+ . 3.8 adds TypedDict, but it is not clear why `typing_extensions` was not used to provide it. Perhaps the original comment predates our inclusion of `typing_extensions` in globus-sdk dependencies. The changeset could either be considered an addition, an enhancement, or a bugfix. It is therefore qualified under the most generic changelog category of "change".
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus and
kurtmckee
as code owners
kurtmckee
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits here.
The first is the "core" change, with minimal edits to the codebase. The second is an attempt to resolve a "TODO" left over from pre-3.7 requirements (and from before our use of typing-extensions, I believe).
The use of TypedDict requires a little bit more verbosity, and could be refactored in a number of ways, but eliminates the need for a cast or type ignore.
That said, if it's controversial, I'd add a revert commit which switches to a type ignore comment and removes the TypedDict usage.
📚 Documentation preview 📚: https://globus-sdk-python--997.org.readthedocs.build/en/997/