Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve operation_symlink warning #941

Merged
merged 1 commit into from
Jan 29, 2024
Merged

improve operation_symlink warning #941

merged 1 commit into from
Jan 29, 2024

Conversation

aaschaer
Copy link
Contributor

@aaschaer aaschaer commented Jan 29, 2024

Noticed this was missed in #940


📚 Documentation preview 📚: https://globus-sdk-python--941.org.readthedocs.build/en/941/

@aaschaer aaschaer added the no-news-is-good-news This change does not require a news file label Jan 29, 2024
Copy link
Member

@sirosen sirosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I noticed it was a pre-existing warning and decided not to touch it.

I'd like to check in with the Transfer team at some point about the future of symlink support (should we remove this API in SDKv4?).

@aaschaer
Copy link
Contributor Author

aaschaer commented Jan 29, 2024

Yeah, I noticed it was a pre-existing warning and decided not to touch it.

I just added the warning in #938 since the transfer docs it linked to were removed alongside the v4 cleanups.

I'd like to check in with the Transfer team at some point about the future of symlink support (should we remove this API in SDKv4?).

I'll ask, but I haven't heard anything recently. I'd say remove it in v4 since it can be re-added easily

@sirosen
Copy link
Member

sirosen commented Jan 29, 2024

Oh, I missed that it was new! Totally slipped past me.
I'll add a runtime deprecation (RemovedInV4Warning) in a separate PR so you can see the bits for it more clearly. (I think you've seen these, but it's always nice to have an example.)

@sirosen sirosen merged commit d25dbaf into main Jan 29, 2024
30 of 31 checks passed
@sirosen sirosen deleted the aaron/symlink_warning branch January 29, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-news-is-good-news This change does not require a news file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants