Update pre-commit hooks & apply #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily, this applies the slyp-driven change to have a return type annotation of `None` on all initializers.
sirosen
requested review from
derek-globus,
kurtmckee,
m1yag1,
MaxTueckeGlobus and
aaschaer
as code owners
kurtmckee
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily, this applies the slyp-driven change to have a return type annotation of
Noneon all initializers.In #1121, I noticed that our hooks were a bit behind. Manually doing the update (rather than waiting for pre-commit.com) lets us apply the autofixing changes right away.
📚 Documentation preview 📚: https://globus-sdk-python--1122.org.readthedocs.build/en/1122/