Refactor LoginFlowManager interactions with GlobusApp #1018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some changes to the way LoginFlowManagers are handled in GlobusApp to improve the native login experience, support confidential clients in UserApps, and make it easier to configure the correct login_flow_manager.
Changelog
Changed the experimental
GlobusApp
class in the following ways (:pr:NUMBER
):LoginFlowManagers
now insertGlobusApp.app_name
into any Nativeclient login flows as the
prefill_named_grant
.GlobusAppConfig
now accepts alogin_redirect_uri
parameter to specifythe redirect URI for a login flow.
Invalid when used with a
LocalServerLoginFlowManager
.Defaults to
"https://auth.globus.org/v2/web/auth-code"
for nativeclient flows. Raises an error if not set for confidential ones.
UserApp
now allows for the use of Confidential client flows with the use ofeither a
LocalServerLoginFlowManager
or a configuredlogin_redirect_uri
.GlobusAppConfig.login_flow_manager
now accepts shorthand string references"command-line"
to use aCommandLineLoginFlowManager
and"local-server"
to use aLocalServerLoginFlowManager
.GlobusAppConfig.login_flow_manager
also now accepts aLoginFlowManagerProvider
, a class with afor_globus_app(...) -> LoginFlowManager
class method.📚 Documentation preview 📚: https://globus-sdk-python--1018.org.readthedocs.build/en/1018/