Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New example doc format #1008
New example doc format #1008
Changes from 1 commit
7499e52
3977f46
1050b68
200c897
968f024
c77f29a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing that
submit_transfer/
andschedule_transfer/
are expected to have example files that could stand to be grouped in the same subdirectory, but is there an expectation thattask_deadlines
andrecursive_ls
make more sense to deviate from that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think each should be using
/index
pages, but it doesn't need to happen this minute.We moved several of these to dirs to be able to make their example scripts separate files which are available for download. I would like to employ that structure everywhere, but we can partially do it as we work through these examples and fill them out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was basically my thought.
I'm not sure which camp each example will fall into but as I fill them in, I'll be editing them into the more accurate one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not characterize either case as typical. In my experience, our users break into three basic groups:
And the latter two groups are more similar than the first.
If anything, knowing both of your collection IDs ahead of time is the exception, not the rule.
Do I object to the ordering used in this doc, or the overall presentation? Eh. Definitely not strongly, but this note jumps out at me and makes me feel that something is slightly amiss. I'm not sure, but I think that we should actually have a preamble that says:
with intra-document links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I can take another stab at this doc with the preamble you suggest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the doc to be less assumptive; lemme know what you think now.
Updated Doc: https://globus-sdk-python--1008.org.readthedocs.build/en/1008/experimental/examples/transferring_data/submit_transfer/index.html