Mapped Collection delete_protected implies v1.8.0

Fix the omission from DATATYPE_VERSION_IMPLICATIONS and add tests.
globus · Dec 12, 2023 · 99035ca · 99035ca
1 parent e83120e
commit 99035ca
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/globus_sdk/services/gcs/data/collection.py b/src/globus_sdk/services/gcs/data/collection.py
@@ -126,6 +126,7 @@ class CollectionDocument(utils.PayloadWrapper, abc.ABC):
 
     DATATYPE_BASE: str = "collection"
     DATATYPE_VERSION_IMPLICATIONS: dict[str, tuple[int, int, int]] = {
+        "delete_protected": (1, 8, 0),
         "guest_auth_policy_id": (1, 6, 0),
         "disable_anonymous_writes": (1, 5, 0),
         "force_verify": (1, 4, 0),

diff --git a/tests/unit/helpers/gcs/test_collections.py b/tests/unit/helpers/gcs/test_collections.py
@@ -71,6 +71,17 @@ def test_datatype_version_deduction(use_kwargs, doc_version):
         ({"disable_anonymous_writes": True}, "1.5.0"),
         ({"disable_anonymous_writes": False}, "1.5.0"),
         ({"guest_auth_policy_id": str(uuid.uuid4())}, "1.6.0"),
+        ({"delete_protected": False}, "1.8.0"),
+        # combining a long user_message (which uses callback-based detection) with
+        # higher and lower bounding fields needs to apply correctly
+        (
+            {"force_verify": False, "user_message": "long message..." + "x" * 100},
+            "1.7.0",
+        ),
+        (
+            {"delete_protected": False, "user_message": "long message..." + "x" * 100},
+            "1.8.0",
+        ),
     ],
 )
 def test_datatype_version_deduction_mapped_specific_fields(use_kwargs, doc_version):