Fix theme issues and revise incorrect intro copy #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ada <[email protected]>
Signed-off-by: Ada <[email protected]>
Signed-off-by: Ada <[email protected]>
Signed-off-by: Ada <[email protected]>
ada-globus
requested review from
derek-globus,
jakeglobus,
kurtmckee,
MaxTueckeGlobus and
sirosen
as code owners
Signed-off-by: Ada <[email protected]>
ada-globus
force-pushed
the
an/fix-theme-issues
branch
from
9c2ed27 to
07d7b75
Compare
kurtmckee
reviewed
Nov 19, 2024
docs/source/conf.py
Outdated
| "sidebar/brand.html", | ||
| "sidebar/search.html", | ||
| "sidebar/navigation.html", | ||
| "sidebar/ethical-ads.html", |
There was a problem hiding this comment.
Hang on, what's this bit right here?
There was a problem hiding this comment.
Ahh, I think we can omit that, actually—I suspect the default is fine for our purpose. I'll strike it.
There was a problem hiding this comment.
Does the default include that ethical-ads bit?
Signed-off-by: Ada <[email protected]>
kurtmckee
approved these changes
Nov 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't attempt to fully remedy all that probably could/should be; I just made the minimum viable set of moves to address everything in my immediate field of view.