Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List typing #389

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

List typing #389

wants to merge 2 commits into from

Conversation

daveisfera
Copy link
Contributor

@daveisfera daveisfera commented Nov 8, 2024 •
edited
Loading

This is using List from typing but once #391 is merged, I can rebase this and just use list

mauricioabreu
mauricioabreu approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@mauricioabreu mauricioabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!

mauricioabreu
mauricioabreu reviewed Nov 9, 2024
View reviewed changes
m3u8/model.py
@@ -449,6 +450,15 @@ def _create_sub_directories(self, filename):
os.makedirs(basename, exist_ok=True)


T = TypeVar("T")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the Generics support that was added in 3.12

@daveisfera
Copy link
Contributor Author

Rebased and ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauricioabreu mauricioabreu mauricioabreu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daveisfera @mauricioabreu