Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosave on clicking cancel #3143

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Autosave on clicking cancel #3143

merged 3 commits into from
Nov 25, 2024

Conversation

akanshaaa19
Copy link
Member

ERP feedback:

  1. If the details in confirmation page (4th page of onboarding form) are filled and if we go back to Billing page- change any details (like billing frequency) and again come back to Comfirmation page, then the details added earlier gets vanished.

Clicking on cancel was not autosaving the data for the form

@akanshaaa19 akanshaaa19 self-assigned this Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 08:04 Inactive
Copy link

cypress bot commented Nov 25, 2024

Glific    Run #5411

Run Properties:  status check passed Passed #5411  •  git commit a31afb6b92 ℹ️: Merge ed6a10e6d7e9a5e02664284b3b14474bf668077d into 78d8b5584c7025d3c60c0c49cc41...
Project Glific
Branch Review fix/autosave-registration-form
Run status status check passed Passed #5411
Run duration 25m 23s
Commit git commit a31afb6b92 ℹ️: Merge ed6a10e6d7e9a5e02664284b3b14474bf668077d into 78d8b5584c7025d3c60c0c49cc41...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 09:56 Inactive
@akanshaaa19 akanshaaa19 requested a review from kurund November 25, 2024 09:59
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.72%. Comparing base (d041350) to head (dd7c050).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3143      +/-   ##
==========================================
+ Coverage   81.56%   81.72%   +0.15%     
==========================================
  Files         329      329              
  Lines       10556    10558       +2     
  Branches     2233     2233              
==========================================
+ Hits         8610     8628      +18     
+ Misses       1329     1315      -14     
+ Partials      617      615       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 23:39 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kurund kurund merged commit 5a3b2b6 into master Nov 25, 2024
12 of 13 checks passed
@kurund kurund deleted the fix/autosave-registration-form branch November 25, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released on production
Development

Successfully merging this pull request may close these issues.

2 participants