-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autosave on clicking cancel #3143
Conversation
🚀 Deployed on https://deploy-preview-3143--glific-frontend.netlify.app |
Glific Run #5411
Run Properties:
|
Project |
Glific
|
Branch Review |
fix/autosave-registration-form
|
Run status |
Passed #5411
|
Run duration | 25m 23s |
Commit |
a31afb6b92 ℹ️: Merge ed6a10e6d7e9a5e02664284b3b14474bf668077d into 78d8b5584c7025d3c60c0c49cc41...
|
Committer | Akansha Sakhre |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
169
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3143 +/- ##
==========================================
+ Coverage 81.56% 81.72% +0.15%
==========================================
Files 329 329
Lines 10556 10558 +2
Branches 2233 2233
==========================================
+ Hits 8610 8628 +18
+ Misses 1329 1315 -14
+ Partials 617 615 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
ERP feedback:
Clicking on cancel was not autosaving the data for the form