ERP: Modifications in registration form

[akanshaaa19]

target issue is #3105

[github-actions]

🚀 Deployed on https://deploy-preview-3127--glific-frontend.netlify.app

[cypress]

Glific    Run #5390

Run Properties:   Passed #5390  •  2b416f2d2a ℹ️: Merge 432e047feb400027ebf234c8bff3d63b91d028b1 into 5974bf1510b7f8e33a4f29603f4e...

Project	Glific
Branch Review	enhancement/erp
Run status	Passed #5390
Run duration	24m 36s
Commit	2b416f2d2a ℹ️: Merge 432e047feb400027ebf234c8bff3d63b91d028b1 into 5974bf1510b7f8e33a4f29603f4e...
Committer	Akansha Sakhre
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	169
View all changes introduced in this branch ↗︎

[codecov]

Codecov Report

Attention: Patch coverage is 56.19048% with 46 lines in your changes missing coverage. Please review.

Project coverage is 81.51%. Comparing base (14f5355) to head (dded038).
Report is 22 commits behind head on master.

Files with missing lines	Patch %	Lines
...Organization/Onboarding/Steps/SigningAuthority.tsx	40.74%	15 Missing and 1 partial ⚠️
...s/Organization/Onboarding/Steps/PaymentDetails.tsx	66.66%	8 Missing and 1 partial ⚠️
...iners/Organization/Onboarding/Steps/OrgDetails.tsx	53.33%	5 Missing and 2 partials ⚠️
.../Organization/Onboarding/Steps/PlatformDetails.tsx	46.15%	6 Missing and 1 partial ⚠️
.../Organization/Onboarding/FormLayout/FormLayout.tsx	0.00%	3 Missing and 1 partial ⚠️
.../Organization/Onboarding/Steps/Address/Address.tsx	83.33%	0 Missing and 2 partials ⚠️
...nization/Onboarding/PaymentType/PaymentOptions.tsx	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3127      +/-   ##
==========================================
- Coverage   81.72%   81.51%   -0.21%     
==========================================
  Files         328      329       +1     
  Lines       10484    10545      +61     
  Branches     2222     2234      +12     
==========================================
+ Hits         8568     8596      +28     
- Misses       1303     1334      +31     
- Partials      613      615       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[kurund]

@akanshaaa19

1. We need better error handling. If someone tries to register and org does not exist the form fails silently. We should at least show some helpful message.

2. Can you also fix failing unit tests?

3. I am also trying to register a new org: Example NGO and the backend is failing with an error. Note that Example NGO has been added to Frappe.

Let's discuss.

[akanshaaa19]

@akanshaaa19

1. We need better error handling. If someone tries to register and org does not exist the form fails silently. We should at least show some helpful message.
2. Can you also fix failing unit tests?
3. I am also trying to register a new org: Example NGO and the backend is failing with an error. Note that Example NGO has been added to Frappe.

Let's discuss.

1. There is error handling for when org doesn't exist in erp.

2. done 3. yes amisha is looking into that

[kurund]

@akanshaaa19

Can you update the message to: "Example organization not found". Please contact the Glific support team.

[akanshaaa19]

@akanshaaa19

Can you update the message to: "Example organization not found". Please contact the Glific support team.

sure, @AmishaBisht will be doing that from the BE
@kurund

[AmishaBisht]

@akanshaaa19
Can you update the message to: "Example organization not found". Please contact the Glific support team.

sure, @AmishaBisht will be doing that from the BE @kurund

done @akanshaaa19 @kurund

[kurund]

@akanshaaa19

1. In my opinion, we should change the below validation.

Why is this necessary? If it's something to do with the backend then we can automatically do such conversion. Let's chat.

2. Error on GST

This just shows red without any message.

3. Incorrect field label

[kurund]

@AmishaBisht

@akanshaaa19
Can you update the message to: "Example organization not found". Please contact the Glific support team.

sure, @AmishaBisht will be doing that from the BE @kurund

done @akanshaaa19 @kurund

Looks like it's not done, we still have Customer

[AmishaBisht]

@AmishaBisht

@akanshaaa19
Can you update the message to: "Example organization not found". Please contact the Glific support team.

sure, @AmishaBisht will be doing that from the BE @kurund

done @akanshaaa19 @kurund

Looks like it's not done, we still have Customer

@kurund the error message I'm receiving is directly from ERP, and I'm passing it along as-is.

[kurund]

Looks good.

Please note the dependency on glific/glific#3893