Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fallback images #3054

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added fallback images #3054

wants to merge 4 commits into from

Conversation

akanshaaa19
Copy link
Member

target issue is #3009

@akanshaaa19 akanshaaa19 self-assigned this Sep 3, 2024
@akanshaaa19 akanshaaa19 linked an issue Sep 3, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 3, 2024

@github-actions github-actions bot temporarily deployed to pull request September 3, 2024 09:22 Inactive
Copy link

cypress bot commented Sep 3, 2024

Glific    Run #5165

Run Properties:  status check failed Failed #5165  •  git commit 071f58fbe6 ℹ️: Merge 0c84f6500f5c31566ce276094bcf46c7d8a88657 into 7584cb043a2b95cfc8c45a2fd63b...
Project Glific
Branch Review fix/hsm-fallback-images
Run status status check failed Failed #5165
Run duration 25m 39s
Commit git commit 071f58fbe6 ℹ️: Merge 0c84f6500f5c31566ce276094bcf46c7d8a88657 into 7584cb043a2b95cfc8c45a2fd63b...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 168
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/trigger/Trigger.spec.ts • 1 failed test

View Output

Test Artifacts
Triggers (daily) > should create new trigger Test Replay Screenshots

@github-actions github-actions bot temporarily deployed to pull request September 3, 2024 17:44 Inactive
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.10%. Comparing base (7584cb0) to head (0c84f65).
Report is 99 commits behind head on master.

Files with missing lines Patch % Lines
src/containers/Template/Form/Template.tsx 75.00% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3054      +/-   ##
==========================================
- Coverage   80.16%   80.10%   -0.07%     
==========================================
  Files         322      322              
  Lines       10363    10370       +7     
  Branches     2207     2212       +5     
==========================================
- Hits         8308     8307       -1     
- Misses       1414     1417       +3     
- Partials      641      646       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akanshaaa19 akanshaaa19 requested a review from kurund September 3, 2024 18:33
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check #3009 (comment)

@kurund kurund added the on hold This is on hold label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold This is on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HSM Template: Adding fallback image
2 participants