Server able to close all connections for given user #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like the idea behind this... can you think of any way to make this more generic? As an example, I've been experimenting with a git server in go, but it would be hard to use this there because traditionally everyone SSHs in as the |
kissgyorgy
reviewed
Oct 30, 2019
| @@ -323,6 +326,19 @@ func (srv *Server) SetOption(option Option) error { | |||
| return option(srv) | |||
| } | |||
|
|
|||
| func (srv *Server) CloseConnectionsForUser(user string) { | |||
There was a problem hiding this comment.
This is too specific to your use-case. A better way to generalize this would be to make connections exported or a hook to get all connections or something, so the specific implementations can do whatever they want with all the connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.