Fixed DictFile.append(), Glidein logging, and added logserver #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mambelli
force-pushed
the
v310/add_logserver_and_fix_glidein_logging_v2
branch
from
af95000 to
83a5f5c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mambelli
force-pushed
the
v310/add_logserver_and_fix_glidein_logging_v2
branch
9 times, most recently
from
d8181ec to
91cfd5f
Compare
append was used only for environment variables in the condor submit file and was causing a malformed submit file add_environment was already used at times and is a better method. append was fixed and is still there commented in case we'd like to use it for other attributes in the future
mambelli
force-pushed
the
v310/add_logserver_and_fix_glidein_logging_v2
branch
from
91cfd5f to
2b33bc0
Compare
namrathaurs
reviewed
Dec 19, 2024
mambelli
force-pushed
the
v310/add_logserver_and_fix_glidein_logging_v2
branch
2 times, most recently
from
3141a0d to
fa3dbd6
Compare
namrathaurs
previously approved these changes
Dec 19, 2024
mambelli
force-pushed
the
v310/add_logserver_and_fix_glidein_logging_v2
branch
3 times, most recently
from
e8196fd to
327d3c2
Compare
|
@namrathaurs Sorry for the after-review changes. Testing the RPM installed version I noticed that there were some missing parts (only in my manual deployment) and I improved also the error checking. |
namrathaurs
previously requested changes
Dec 24, 2024
Added php and python example for a server receiving Glidein logs Fixed JWT generation and GLIDEIN_LOG_RECIPIENTS_FACTORY param for Factory logserver, improved also code and docstrings, and added documentation for logging and log server Refactored the logging utility to have all public functions starting with 'glog_' Added an example custom script, logging_test.sh, using Glidein logging Fixed mod_ssl dependency, fixed ReleaseManagerLib bugs for RPM building, and replaced the deprecated optparse with argparse Added the glideinwms-logserver RPM and adjusted ReleaseManagerLib for it Thanks to @namrathaurs for the review and the suggestion to remove all the example secrets TODO: changes to url_dirs.desc require factory upgrade. Should a reconfig be sufficient?
mambelli
force-pushed
the
v310/add_logserver_and_fix_glidein_logging_v2
branch
from
327d3c2 to
815a049
Compare
namrathaurs
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed and disabled DictFile.append(), replaced by add_environment()
append was used only for environment variables in the condor submit file and was causing a malformed submit file.
add_environment was already used at times and is a better method. append was fixed and is still there commented in case we'd like to use it for other attributes in the future.