forked from moogar0880/PyTrakt
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Add IdsMixin to replace extract_ids() utility method #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
glensc
changed the title
Move extract_ids(media_item) to be able to make atomic commits
Refactor: Add IdsMixin to replace extract_ids() utility method
Dec 11, 2022
LGTM. Tested:
|
This was referenced Dec 11, 2022
This was referenced Dec 11, 2022
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carry moogar0880#186
Extracting the "ids" on each response is tedious, and such duplication results users being confused:
Also, the existing extraction is inconsistent (Not applied for TVShow and Movie in this example):
This will make the ids extraction automatic, and prevent updating the attributes directly.
Additionally it came out that properties like
tmdb_id
,imdb_id
,trakt_id
are unused. they are initialized asNone
in the constructor but never any other value. these are commented with@deprecated
and are to be removed in 4.x.TODO: