Add section on JavaScript interop for custom types #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Sep 9, 2023
book-src/tour/custom-types.md
Outdated
| // JavaScript | ||
| new Guest(); // => {} | ||
| new LoggedIn("Kim"); // => { 0: "Kim" } | ||
| new Animal("Jinx", 2002); // => { name: "Jinx", cuteness: 2002 } |
There was a problem hiding this comment.
Could you remove these comments? They're not accurate, and I think the constructors on the left are clear enough.
There was a problem hiding this comment.
Yeah, I was trying to find a way to explain how to access named and unnamed properties. Maybe we could do something like
const user = new LoggedIn("Kim");
user[0] === "Kim";
const cat = new Cat("Jinx", 2002);
cat.cuteness === 2002;Not sure if that's overkill
That's a good idea actually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #200.
Does something like this look reasonable?