Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add php8 nullsafe operator #662

Merged
merged 4 commits into from
Feb 24, 2021

Conversation

Selion05
Copy link
Contributor

#658 - Work in progress. Any feedback?

@czosel
Copy link
Collaborator

czosel commented Feb 21, 2021

Looks good! Can you add a test?

I created a new branch called php8 - I'd say we merge this into that branch first, such that @ichiriac can still take a look at the changes before it's merged into master.

@Selion05
Copy link
Contributor Author

A separate branch sounds good.

I added tests, basically I replicated most of the propertylookup tests. I just had a quick glance on the snapshots so they need some review!

@Selion05 Selion05 changed the base branch from master to php8 February 23, 2021 15:30
@czosel
Copy link
Collaborator

czosel commented Feb 23, 2021

I also didn't check all the snapshots, but what I saw looks good to me. Can you rebase on the current master? Then the CI should work as well, and we can start merging into the php8 branch 👍

@Selion05 Selion05 force-pushed the issue-658-null-safe-operator branch from c7d6ae8 to 4ca49ba Compare February 24, 2021 09:31
Copy link
Collaborator

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@czosel czosel merged commit 7de81ca into glayzzle:php8 Feb 24, 2021
@czosel
Copy link
Collaborator

czosel commented Feb 24, 2021

It would probably be a good idea to open a PR at the prettier php plugin that’s based on the php8 branch - sometimes we still notice some quirks when using the new features 🙃

@cseufert cseufert mentioned this pull request Mar 22, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants