Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Typed Class Constants parsing #1147

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix Typed Class Constants parsing #1147

merged 1 commit into from
Dec 4, 2024

Conversation

genintho
Copy link
Collaborator

@genintho genintho commented Dec 4, 2024 •
edited
Loading

Class using untyped constant are breaking the parser when using 8.3

class Foo { 
const CONSTANT = "Hello world!"; 
}

The problem came from read_optional_type which was returning a "type" even if the statement did not have a type.

@genintho genintho force-pushed the genintho-constant-v2 branch from 786552c to e8fdcdb Compare December 4, 2024 04:50
@genintho genintho mentioned this pull request Dec 4, 2024
Closed
czosel
czosel approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this @genintho!

@czosel czosel merged commit 9c5902b into glayzzle:main Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czosel czosel czosel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@genintho @czosel