-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies #1139
Conversation
de89542
to
6523644
Compare
This also includes major version bumps of prettier and eslint, which triggered some changes.
6523644
to
d862033
Compare
CI is currently failing with errors like this:
I have no typescript experience - any pointers are appreciated! |
I am pretty sure we do not want |
ok on further investigation, it appears that webpack imports @types/eslint-scope however the actualy eslint package looks to have updated typescript types. I am not sure how to solve this, without a PR to webpack to update its use of the eslint-scope types to consume directly from eslint. |
Well rolling back webpack to 5.96.0 to avoid this fix: webpack/webpack#18916 has resulted in
which make no sense either. |
@cseufert Thanks for looking into this! I tried following up on the remaining error, and it seems that installing a more recent version of |
@cseufert CI seems to pass now. Let me know if this is ready to be merged from your side :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.