Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #1139

Merged
merged 5 commits into from
Nov 8, 2024
Merged

chore: update dependencies #1139

merged 5 commits into from
Nov 8, 2024

Conversation

czosel
Copy link
Collaborator

@czosel czosel commented Nov 6, 2024

No description provided.

@czosel czosel force-pushed the upgrade-deps-3 branch 2 times, most recently from de89542 to 6523644 Compare November 6, 2024 22:23
This also includes major version bumps of prettier and eslint, which
triggered some changes.
@czosel
Copy link
Collaborator Author

czosel commented Nov 6, 2024

CI is currently failing with errors like this:

Error: node_modules/@types/eslint-scope/index.d.ts(50,5): error TS2416: Property 'writeExpr' in type 'Reference' is not assignable to the same property in base type 'Reference'.

I have no typescript experience - any pointers are appreciated!

cc @ichiriac @cseufert

@cseufert
Copy link
Collaborator

cseufert commented Nov 6, 2024

I am pretty sure we do not want @types/eslint-scope to be installed, as it seems to be out of date, and eslint seems to have the types included already

@cseufert
Copy link
Collaborator

cseufert commented Nov 6, 2024

ok on further investigation, it appears that webpack imports @types/eslint-scope however the actualy eslint package looks to have updated typescript types. I am not sure how to solve this, without a PR to webpack to update its use of the eslint-scope types to consume directly from eslint.

@cseufert
Copy link
Collaborator

cseufert commented Nov 6, 2024

Well rolling back webpack to 5.96.0 to avoid this fix: webpack/webpack#18916

has resulted in

Error: node_modules/@types/node/module.d.ts(108,13): error TS2386: Overload signatures must all be optional or required.

which make no sense either.

@czosel
Copy link
Collaborator Author

czosel commented Nov 7, 2024

@cseufert Thanks for looking into this! I tried following up on the remaining error, and it seems that installing a more recent version of @types/node fixes the issue: DefinitelyTyped/DefinitelyTyped#70562 (comment)

@czosel
Copy link
Collaborator Author

czosel commented Nov 7, 2024

@cseufert CI seems to pass now. Let me know if this is ready to be merged from your side :-)

Copy link
Collaborator

@cseufert cseufert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czosel czosel merged commit 7d8c5cc into main Nov 8, 2024
6 checks passed
@czosel czosel deleted the upgrade-deps-3 branch November 8, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants