removed the duplicate "Record with no link" dataset

gkeimeHDF · Jul 24, 2024 · 0587e8a · 0587e8a
1 parent 8ddb832
commit 0587e8a
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 14 deletions.
diff --git a/apps/datahub-e2e/src/e2e/datasetDetailPage.cy.ts b/apps/datahub-e2e/src/e2e/datasetDetailPage.cy.ts
@@ -596,7 +596,7 @@ describe('dataset pages', () => {
         })
       })
 
-      describe.only('When there is no link', () => {
+      describe('When there is no link', () => {
         it('display the error datasetHasNoLink error block', () => {
           cy.login()
 

diff --git a/apps/datahub/src/app/record/record-metadata/record-metadata.component.spec.ts b/apps/datahub/src/app/record/record-metadata/record-metadata.component.spec.ts
@@ -45,6 +45,7 @@ class MdViewFacadeMock {
   otherLinks$ = new BehaviorSubject([])
   related$ = new BehaviorSubject(null)
   error$ = new BehaviorSubject(null)
+  isMetadataLoading$ = new BehaviorSubject(false)
 }
 
 class SearchServiceMock {
@@ -659,20 +660,39 @@ describe('RecordMetadataComponent', () => {
     })
 
     describe('When there are no link (download, api or other links)', () => {
-      beforeEach(() => {
-        facade.apiLinks$.next([])
-        facade.downloadLinks$.next([])
-        facade.otherLinks$.next([])
-        fixture.detectChanges()
+      describe('When the metadata is not fully loaded', () => {
+        beforeEach(() => {
+          facade.isMetadataLoading$.next(true)
+          facade.apiLinks$.next([])
+          facade.downloadLinks$.next([])
+          facade.otherLinks$.next([])
+          fixture.detectChanges()
+        })
+        it("doesn' show the no link error block", () => {
+          const result = fixture.debugElement.query(
+            By.css('[data-test="dataset-has-no-link-block"]')
+          )
+          expect(result).toBeFalsy()
+        })
       })
-      it('shows the no link error block', () => {
-        const result = fixture.debugElement.query(
-          By.css('[data-test="dataset-has-no-link-block"]')
-        )
-        expect(result).toBeTruthy()
-        expect(result.componentInstance.type).toBe(
-          ErrorType.DATASET_HAS_NO_LINK
-        )
+
+      describe('When the metadata is not fully loaded', () => {
+        beforeEach(() => {
+          facade.isMetadataLoading$.next(false)
+          facade.apiLinks$.next([])
+          facade.downloadLinks$.next([])
+          facade.otherLinks$.next([])
+          fixture.detectChanges()
+        })
+        it('shows the no link error block', () => {
+          const result = fixture.debugElement.query(
+            By.css('[data-test="dataset-has-no-link-block"]')
+          )
+          expect(result).toBeTruthy()
+          expect(result.componentInstance.type).toBe(
+            ErrorType.DATASET_HAS_NO_LINK
+          )
+        })
       })
     })
   })

diff --git a/support-services/docker-entrypoint-initdb.d/dump b/support-services/docker-entrypoint-initdb.d/dump