Fix 'A lock was created but not released at' error?

gjbarnard · Oct 26, 2023 · e2e6d0b · e2e6d0b
1 parent dbfad48
commit e2e6d0b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/classes/toolbox.php b/classes/toolbox.php
@@ -615,7 +615,7 @@ private static function update_the_displayed_images($courseid = null) {
         if (!empty($coursesectionimages)) {
             $fs = get_file_storage();
             $lockfactory = null;
-            $lock = true;
+            $lock = null;
             if (!defined('BEHAT_SITE_RUNNING')) {
                 $lockfactory = \core\lock\lock_config::get_lock_factory('format_grid');
             }
@@ -630,7 +630,7 @@ private static function update_the_displayed_images($courseid = null) {
                 if (!defined('BEHAT_SITE_RUNNING')) {
                     $lock = $lockfactory->get_lock('sectionid'.$coursesectionimage->sectionid, 5);
                 }
-                if ($lock) {
+                if (($lock instanceof \core\lock\lock) || (defined('BEHAT_SITE_RUNNING'))) {
                     $files = $fs->get_area_files($coursecontext->id, 'format_grid', 'sectionimage', $coursesectionimage->sectionid);
                     foreach ($files as $file) {
                         if (!$file->is_directory()) {