Fix 'A lock was created but not released at' error?

gjbarnard · Dec 10, 2023 · 3fd3e5c · 3fd3e5c
1 parent c60f847
commit 3fd3e5c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/classes/toolbox.php b/classes/toolbox.php
@@ -678,7 +678,7 @@ private static function update_the_displayed_images($courseid = null) {
         if (!empty($coursesectionimages)) {
             $fs = get_file_storage();
             $lockfactory = null;
-            $lock = true;
+            $lock = null;
             if (!defined('BEHAT_SITE_RUNNING')) {
                 $lockfactory = \core\lock\lock_config::get_lock_factory('format_grid');
             }
@@ -693,7 +693,7 @@ private static function update_the_displayed_images($courseid = null) {
                 if (!defined('BEHAT_SITE_RUNNING')) {
                     $lock = $lockfactory->get_lock('sectionid' . $coursesectionimage->sectionid, 5);
                 }
-                if ($lock) {
+                if (($lock instanceof \core\lock\lock) || (defined('BEHAT_SITE_RUNNING'))) {
                     $files = $fs->get_area_files($coursecontext->id, 'format_grid', 'sectionimage', $coursesectionimage->sectionid);
                     foreach ($files as $file) {
                         if (!$file->is_directory()) {