Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: move evaluator external log processing here #3804

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

esbena
Copy link

@esbena esbena commented Nov 13, 2024

This is a PoC for moving the external implementations we have for evaluator log processing into this repository.
This does not yet modify the runtime of this repository, but it does add immutable.js to the package.json file.

Of particular hackathon interest is the local testing feature:

* $ ts-node cli.ts badness-metrics codeql ~/Downloads/codeql-evaluator-log.json

And the TypeScript versions of those:

/**
* Computes the "badness metric" from an `predicates` summary of an evaluator log file.
*
* The resulting file is a JSON-encoded value of type {@link BadnessMetrics}.
*
* If `badnessMetricsFile` already exists, it is not overwritten.
*/
export async function process(
codeqlPath: string,

@esbena esbena requested a review from a team as a code owner November 13, 2024 11:19
@esbena esbena requested a review from asgerf November 13, 2024 11:22
@esbena
Copy link
Author

esbena commented Nov 13, 2024

(the test failures have nothing to do with my changes) they do now

@esbena esbena force-pushed the esbena/evaluator-log-processing-2 branch 3 times, most recently from faea958 to e71a04a Compare November 14, 2024 10:19
This is a PoC for moving the external implementations we have for evaluator log processing into this repository.
This does not yet modify the runtime of this repository, but it does add immutable.js to the package.json file.
@esbena esbena force-pushed the esbena/evaluator-log-processing-2 branch from e71a04a to 11a0fb5 Compare November 14, 2024 10:49
@esbena esbena merged commit b3551b0 into hackathon/compare-perf Nov 14, 2024
13 checks passed
@esbena esbena deleted the esbena/evaluator-log-processing-2 branch November 14, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants