Release 16.0 GitHub #70

…ssio#11987) Signed-off-by: Harshit Gangal <[email protected]> Signed-off-by: Harshit Gangal <[email protected]>

GitHub did not seem to pick up the merge conflict between these two commits (older to newer): - vitessio@673573a - vitessio@836b3c1 The first commit changed the function signature for testOnlineDDLStatement(), while the later commit used the old signature. Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Matt Lord <[email protected]>

* Remove dead Workflow mgmt code This was pre-Legacy sharding, which was in turn pre-VReplication. Signed-off-by: Matt Lord <[email protected]> * Remove related proto Signed-off-by: Matt Lord <[email protected]> * Get rid of related flag usage Signed-off-by: Matt Lord <[email protected]> * Add release notes line and run go mod tidy Signed-off-by: Matt Lord <[email protected]> * Add missing command to removed list in release notes Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Matt Lord <[email protected]>

* ComBinlogDumpGTID: receive logFile, logPos Signed-off-by: Shlomi Noach <[email protected]> * fix error code Signed-off-by: Shlomi Noach <[email protected]> * kontinue by default true Signed-off-by: Shlomi Noach <[email protected]> * - Added `parseComBinlogDump` - Added `BinlogEvent.IsHeartbeat()` - Fixed `NewRotateEvent()` bug - Added `NewFakeRotateEvent()` - Added `NewHeartbeatEvent()` - `mysql/conn.go` handles `ComBinlogDump` - `mysql/conn.go` handles `ComRegisterReplica` - Added `Conn.WriteBinlogEvent()` - `SendBinlogDumpCommand()` accepts a binlog file name, per https://dev.mysql.com/doc/internals/en/com-binlog-dump-gtid.html Signed-off-by: Shlomi Noach <[email protected]> * adding a couple unit tests Signed-off-by: Shlomi Noach <[email protected]> * updates to go/mysql/binlog_event_make.go Signed-off-by: Shlomi Noach <[email protected]> * updates to go/mysql/conn.go Signed-off-by: Shlomi Noach <[email protected]> * more tests Signed-off-by: Shlomi Noach <[email protected]> * endtoend/cluster: create a cluster without assuming availability of binaries Signed-off-by: Shlomi Noach <[email protected]> * endtoend/cluster: more MysqlctlProcess functionality Signed-off-by: Shlomi Noach <[email protected]> * indentation Signed-off-by: Shlomi Noach <[email protected]> * QueryMatchesTemplates: CanonicalString Signed-off-by: Shlomi Noach <[email protected]> * fix comments Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Shlomi Noach <[email protected]>

* Propagate binlog stream errors Signed-off-by: Matt Lord <[email protected]> * Add new unit test Signed-off-by: Matt Lord <[email protected]> * Ensure err channel I/O does not block on ctx cancellation For example, during PRS. Signed-off-by: Matt Lord <[email protected]> * Remove unnecessary WaitGroup usage in unit test Signed-off-by: Matt Lord <[email protected]> * Log error message when context is closed. This maintains the previous behavior for the log messages and ensures that is consistent when the context is closed or not. Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Matt Lord <[email protected]>

* feat: add failing parsing test and fix parser Signed-off-by: Manan Gupta <[email protected]> * test: add e2e tests for interval with math functions Signed-off-by: Manan Gupta <[email protected]> * test: explictly set the time-zone to prevent failures in CI Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]>

* feat: add failing test and fix the query of insertion Signed-off-by: Manan Gupta <[email protected]> * empty-commit Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]>

…itessio#12098) * message Rule: convert_int_to_enum Signed-off-by: Shlomi Noach <[email protected]> * OnlineDDL/vreplication: handle conversion of integral type to enum type Signed-off-by: Shlomi Noach <[email protected]> * admin web proto Signed-off-by: Shlomi Noach <[email protected]> * minor naming and comment changes Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Shlomi Noach <[email protected]>

* store transaction isolation level in upper case Signed-off-by: Harshit Gangal <[email protected]> * store system variables in the case as provided in StorageCase type Signed-off-by: Harshit Gangal <[email protected]> Signed-off-by: Harshit Gangal <[email protected]>

…12105) The canonical string representation needs to keep the correct case for the charset. Those are never upcased in MySQL so we should not enforce that here either. Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]>

…upported (vitessio#12111) Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]>

…o#12107) Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Shlomi Noach <[email protected]>

* test: add a failing test for the case where the port changes for a tablet Signed-off-by: Manan Gupta <[email protected]> * feat: fix the issue by adding alias as a unique field Signed-off-by: Manan Gupta <[email protected]> * empty-commit Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]>

Signed-off-by: notfelineit <[email protected]>

Signed-off-by: Frances Thai <[email protected]>

Signed-off-by: notfelineit <[email protected]>

* Use Gen4 as the default planner version for VTExplain Signed-off-by: Florent Poinsard <[email protected]> * change e2e test output Signed-off-by: Florent Poinsard <[email protected]> * use querypb.ExecuteOptions_DEFAULT_PLANNER as the default vtexplain planner version Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>

* notify view change to vtgate Signed-off-by: Harshit Gangal <[email protected]> * test: added unit test Signed-off-by: Harshit Gangal <[email protected]> * fix: fix e2e test query Signed-off-by: Harshit Gangal <[email protected]> Signed-off-by: Harshit Gangal <[email protected]>

Signed-off-by: notfelineit <[email protected]>

* Update SafeRewrite to allow for replacing a node that we don't want to visit the children of Signed-off-by: Andres Taylor <[email protected]> * Clean up ast_rewriting before refactoring it Signed-off-by: Andres Taylor <[email protected]> * feat: fix usages of Rewrite in ast_rewriting Signed-off-by: Manan Gupta <[email protected]> * feat: fix usages of Rewrite in normalizer Signed-off-by: Manan Gupta <[email protected]> * safe rewrite having clause during horizon planning Signed-off-by: Florent Poinsard <[email protected]> * move rewriteHavingAndOrderBy to safeRewrite Signed-off-by: Florent Poinsard <[email protected]> * refactor: clean up code Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Manan Gupta <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

* feat: remove deprecated fields in logstats Signed-off-by: Manan Gupta <[email protected]> * feat: remove enable_semi_sync Signed-off-by: Manan Gupta <[email protected]> * feat: remove QueryRowCounts stat Signed-off-by: Manan Gupta <[email protected]> * feat: remove deprecated and unused field Signed-off-by: Manan Gupta <[email protected]> * feat: remove unused code Signed-off-by: Manan Gupta <[email protected]> * release-notes: fix review comments in release-notes Signed-off-by: Manan Gupta <[email protected]> * test: remove enable_semi_sync flag from the tests Signed-off-by: Manan Gupta <[email protected]> * feat: remove tests for QueryRowCounts Signed-off-by: Manan Gupta <[email protected]> * feat: deprecate QueriesProcessed and QueriesRouted Signed-off-by: Manan Gupta <[email protected]> * docs: make versions consistant in the release summary Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]>

* Strip secondary keys during schema copy Signed-off-by: Matt Lord <[email protected]> * Save ALTER to run when copy finishes Signed-off-by: Matt Lord <[email protected]> * Move work to vcopier Signed-off-by: Matt Lord <[email protected]> * go mod tidy Signed-off-by: Matt Lord <[email protected]> * Re-apply stashed secondary keys Signed-off-by: Matt Lord <[email protected]> * Minor fixes and cleanup Signed-off-by: Matt Lord <[email protected]> * Add Reshard support Signed-off-by: Matt Lord <[email protected]> * Support multiple SQL actions Signed-off-by: Matt Lord <[email protected]> * Rename action->>"$.action" to action->>"$.task" Signed-off-by: Matt Lord <[email protected]> * Fix unit tests Signed-off-by: Matt Lord <[email protected]> * Add new unit test Signed-off-by: Matt Lord <[email protected]> * Improve the unit test Signed-off-by: Matt Lord <[email protected]> * Add vtctl --defer-secondary-keys client flag Signed-off-by: Matt Lord <[email protected]> * Fix binlog unit tests Signed-off-by: Matt Lord <[email protected]> * Fix wrangler unit tests Signed-off-by: Matt Lord <[email protected]> * Move workflow type check to a function Signed-off-by: Matt Lord <[email protected]> * Update error in unit test and add OnlineDDL Signed-off-by: Matt Lord <[email protected]> * Minor unit test improvements Signed-off-by: Matt Lord <[email protected]> * Improve name of table used Signed-off-by: Matt Lord <[email protected]> * Improvements after self review Signed-off-by: Matt Lord <[email protected]> * Ensure ALTERs are killed when engine shuts down Signed-off-by: Matt Lord <[email protected]> * Fixup & deflake the unit test Signed-off-by: Matt Lord <[email protected]> * Minor improvements after self review Signed-off-by: Matt Lord <[email protected]> * Auto handle more edge cases Signed-off-by: Matt Lord <[email protected]> * More unit test improvements Signed-off-by: Matt Lord <[email protected]> * Address review comments Signed-off-by: Matt Lord <[email protected]> * Correct new error handling in killAction Signed-off-by: Matt Lord <[email protected]> * Improve getTableSecondaryKeys function Signed-off-by: Matt Lord <[email protected]> * Nitty comment improvements Signed-off-by: Matt Lord <[email protected]> * Address review comments Signed-off-by: Matt Lord <[email protected]> * Minor improvements to log message Signed-off-by: Matt Lord <[email protected]> * Fix unit tests Signed-off-by: Matt Lord <[email protected]> * Add defer_secondary_keys to new unit tests added via main merge Signed-off-by: Matt Lord <[email protected]> * More unit test fixes Signed-off-by: Matt Lord <[email protected]> * Minor improvements to the log messages Signed-off-by: Matt Lord <[email protected]> * Minor changes and a fix after self review Signed-off-by: Matt Lord <[email protected]> * Ignore --defer-secondary-keys for Reshard merges Signed-off-by: Matt Lord <[email protected]> * Nitty improvement to comment Signed-off-by: Matt Lord <[email protected]> * Add full support for shard merges Signed-off-by: Matt Lord <[email protected]> * Move newClientConnection() to vreplicator Signed-off-by: Matt Lord <[email protected]> * Add unit test for new behavior Other fixes and minor improvements Signed-off-by: Matt Lord <[email protected]> * Use the engine context rather than vreplicator context Otherwise the ALTER gets KILLed when the copy phase ends Signed-off-by: Matt Lord <[email protected]> * Improve testing and other minor tweaks Signed-off-by: Matt Lord <[email protected]> * Add post copy action cleanup to workflow cancel Signed-off-by: Matt Lord <[email protected]> * More unit test fixes for post copy action cleanup Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Matt Lord <[email protected]>

* add debug tooling Signed-off-by: Andres Taylor <[email protected]> * move dbg to test Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Andres Taylor <[email protected]>

Signed-off-by: notfelineit <[email protected]>

* more testing for getViewDependentTableNames() Signed-off-by: Shlomi Noach <[email protected]> * getForeignKeyParentTableNames Signed-off-by: Shlomi Noach <[email protected]> * schema normalization: sort tables by fk reference order Signed-off-by: Shlomi Noach <[email protected]> * minor test addition Signed-off-by: Shlomi Noach <[email protected]> * ForeignKeyDependencyUnresolvedError Signed-off-by: Shlomi Noach <[email protected]> * InvalidReferencedColumnInForeignKeyConstraintError, MismatchingForeignKeyColumnCountError, MismatchingForeignKeyColumnTypeError Signed-off-by: Shlomi Noach <[email protected]> * rename error: ForeignKeyColumnCountMismatchError Signed-off-by: Shlomi Noach <[email protected]> * rename MismatchingForeignKeyColumnTypeError to ForeignKeyColumnTypeMismatchError Signed-off-by: Shlomi Noach <[email protected]> * changes per review Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Shlomi Noach <[email protected]>

…tld2 [vtctld2] Remove vtctld2 UI and vtctld server components that serve the app UI

* add code for generating copy-on-rewrite logic Signed-off-by: Andres Taylor <[email protected]> * added more tests and started calling cloned Signed-off-by: Andres Taylor <[email protected]> * reformat Signed-off-by: Andres Taylor <[email protected]> * change uses of Clone & Rewrite to CopyOnRewrite Signed-off-by: Andres Taylor <[email protected]> * regenerate test code Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Andres Taylor <[email protected]>

Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Shlomi Noach <[email protected]>

* Create a function to replace glog with PlanetScale log Signed-off-by: Emad Habib <[email protected]> * Add test case for replacing glog Signed-off-by: Emad Habib <[email protected]> * Remove one test Signed-off-by: Emad Habib <[email protected]> * Add flag for PS Logger usage Signed-off-by: Emad Habib <[email protected]> * Update the usage test files and replace _ with - for the flag Signed-off-by: Emad Habib <[email protected]> * Apply code review comments Signed-off-by: Emad Habib <[email protected]> * Add copyrights and release notes Signed-off-by: Emad Habib <[email protected]> * Update the year in the copyrights Signed-off-by: Emad Habib <[email protected]> * Fix typo Signed-off-by: Emad Habib <[email protected]> * Empty Commit Signed-off-by: Emad Habib <[email protected]> Signed-off-by: Emad Habib <[email protected]>

* Fix the syntax of the semgrep action This job is currently always failing since the syntax is wrong. It means you get an alert on it as well on each CI build. Signed-off-by: Dirkjan Bussink <[email protected]> * Remove semgrep action for now We might want to add this back in the future, but now let's delete it since it's broken and not working anyway. Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]>

…sio#12050) * VTGate: Set immediate caller id from gRPC static auth username Signed-off-by: Brendan Dougherty <[email protected]> * Add doc comments to tests Signed-off-by: Brendan Dougherty <[email protected]> Signed-off-by: Brendan Dougherty <[email protected]>

…ements (vitessio#12144) * DDL: do not Reload() for 'CREATE TEMPORARY' and 'DROP TEMPORARY' statements Signed-off-by: Shlomi Noach <[email protected]> * simplified check for temporary table Signed-off-by: Shlomi Noach <[email protected]> * simplified check again for temporary table Signed-off-by: Shlomi Noach <[email protected]> * added plan test to see NeedsReservedConn is true for temporary table create ddl Signed-off-by: Harshit Gangal <[email protected]> * added schema reload timing metric and add test to verify if reload executed on temporary tables Signed-off-by: Harshit Gangal <[email protected]> Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>

…or Vitess in order to get the column types (vitessio#12007) Signed-off-by: Johan Oskarsson <[email protected]> Signed-off-by: Johan Oskarsson <[email protected]> Co-authored-by: Johan Oskarsson <[email protected]>

Signed-off-by: Max Englander <[email protected]> Signed-off-by: Max Englander <[email protected]>

* go/vt/mysqlctl: add compression benchmarks Having compression benchmarks is useful for making decisions about what compressor to choose in backup/restore processes. Signed-off-by: Max Englander <[email protected]> * doc/releasenotes: at 16_0_0 notes about mysqlctl compression benchmarks Signed-off-by: Max Englander <[email protected]> * address pr comments: fetch realistic data to compress Signed-off-by: Max Englander <[email protected]> * address pr comments: provide better benchmark metrics Signed-off-by: Max Englander <[email protected]> * update release notes to reflect new benchmark output Signed-off-by: Max Englander <[email protected]> * add more benchmarks Signed-off-by: Max Englander <[email protected]> * send compressed data to stdout Signed-off-by: Max Englander <[email protected]> * exclude read/write time from benchmarks Signed-off-by: Max Englander <[email protected]> * allow use local path as data url Signed-off-by: Max Englander <[email protected]> * dont download stuff in TestMain Signed-off-by: Max Englander <[email protected]> * use smaller test data file, now in dropbox Signed-off-by: Max Englander <[email protected]> * update release notes Signed-off-by: Max Englander <[email protected]> * download enwiki from vitess-releases Signed-off-by: Max Englander <[email protected]> Signed-off-by: Max Englander <[email protected]>

* make ColumnType a by-ref implementation Signed-off-by: Andres Taylor <[email protected]> * sizegen Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Andres Taylor <[email protected]>

* add translation for between comparisons in the evalengine Signed-off-by: Andres Taylor <[email protected]> * add end to end test Signed-off-by: Andres Taylor <[email protected]> * add support for NOT BETWEEN Signed-off-by: Andres Taylor <[email protected]> * fix translation of NOT BETWEEN Signed-off-by: Andres Taylor <[email protected]> * assert no matter the order of the results Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Andres Taylor <[email protected]>

* deprecate VTExplain endpoint Signed-off-by: Andrew Mason <[email protected]> * release notes Signed-off-by: Andrew Mason <[email protected]> Signed-off-by: Andrew Mason <[email protected]>

…ssio#12175) Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Andres Taylor <[email protected]>

* more testing for getViewDependentTableNames() Signed-off-by: Shlomi Noach <[email protected]> * getForeignKeyParentTableNames Signed-off-by: Shlomi Noach <[email protected]> * schema normalization: sort tables by fk reference order Signed-off-by: Shlomi Noach <[email protected]> * minor test addition Signed-off-by: Shlomi Noach <[email protected]> * ForeignKeyDependencyUnresolvedError Signed-off-by: Shlomi Noach <[email protected]> * InvalidReferencedColumnInForeignKeyConstraintError, MismatchingForeignKeyColumnCountError, MismatchingForeignKeyColumnTypeError Signed-off-by: Shlomi Noach <[email protected]> * validate or autogenerate index on local table based on foreign key constraint columns Signed-off-by: Shlomi Noach <[email protected]> * validate referenced table key Signed-off-by: Shlomi Noach <[email protected]> * ColumnKeyOption consts become public Signed-off-by: Shlomi Noach <[email protected]> * adding DuplicateKeyNameError Signed-off-by: Shlomi Noach <[email protected]> * normalize PRIMARY KEY definition: a 'id int primary key' column definition splits into 'id int' and 'primary key (id)' parts. Primary key is always the first key in the list of keys. Handle queries such as 'modify id int primary key' (validate there isn't already a primary key, or that the existing primary key is over 'id'. add column with primary key definition... Signed-off-by: Shlomi Noach <[email protected]> * further unit test adaptations Signed-off-by: Shlomi Noach <[email protected]> * adapting tests: adding required local index over foreign key columns Signed-off-by: Shlomi Noach <[email protected]> * implicitly add key over foreign key columns if no appropriate key exists Signed-off-by: Shlomi Noach <[email protected]> * normalize CREATE TABLE statement to include missing foreign key indexes Signed-off-by: Shlomi Noach <[email protected]> * rename error: ForeignKeyColumnCountMismatchError Signed-off-by: Shlomi Noach <[email protected]> * rename MismatchingForeignKeyColumnTypeError to ForeignKeyColumnTypeMismatchError Signed-off-by: Shlomi Noach <[email protected]> * changes per review Signed-off-by: Shlomi Noach <[email protected]> * add a few tests that validate an implicit index isn't added if not needed Signed-off-by: Shlomi Noach <[email protected]> * case insensitive column comparison in indexCoversColumnsInOrder and in tests Signed-off-by: Shlomi Noach <[email protected]> * MissingForeignKeyIndexError is not needed bcause, compatible with MySQL behavior, we implicitly add the index if missing Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]>

…art 1 (vitessio#12061) * consolidating OnlineDDL 'declarative' tests into 'scheduler' tests: part 1 Signed-off-by: Shlomi Noach <[email protected]> * increase test timeout Signed-off-by: Shlomi Noach <[email protected]> * fixed comments Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]>

…12124) * fetch views information in tracker and store it Signed-off-by: Harshit Gangal <[email protected]> * update vschema views from tracker Signed-off-by: Harshit Gangal <[email protected]> * fix: use the right case for _vt and table Signed-off-by: Harshit Gangal <[email protected]> * test: added views tracker unit test Signed-off-by: Harshit Gangal <[email protected]> * test: added e2e test for views tracker working Signed-off-by: Harshit Gangal <[email protected]> * add support for views json marshal to be viewable in vtgate ui Signed-off-by: Harshit Gangal <[email protected]> * added e2e test of view and table schema tracking Signed-off-by: Harshit Gangal <[email protected]> * added test for json marshal for vschema views Signed-off-by: Harshit Gangal <[email protected]> * test added to see view definition does not change on select * definition even if table schema is modified Signed-off-by: Harshit Gangal <[email protected]> * addressed review comments Signed-off-by: Harshit Gangal <[email protected]> * improve test with less dependent on fixed time delays Signed-off-by: Harshit Gangal <[email protected]> * fix pending CI failures Signed-off-by: Harshit Gangal <[email protected]> * increase wait time to 10 seconds Signed-off-by: Harshit Gangal <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]>

…p part 2) (vitessio#12182) Signed-off-by: Shlomi Noach <[email protected]>

…itessio#12183) * Online DDL CI: consolidated revertible and revert CI tests Signed-off-by: Shlomi Noach <[email protected]> * changes and comments per review Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]>

We can use big.Int directly to parse this and convert it to bytes. We don't need to parse it into an integer, nor use an intermediate hex encoding either. Signed-off-by: Dirkjan Bussink <[email protected]>

…horitative Map on Tablet Delete (vitessio#12178) * Ensure secondary maps stay in sync with authoritative map on delete Signed-off-by: Matt Lord <[email protected]> * Remove all possible entries for a tablet alias in secondary maps Signed-off-by: Matt Lord <[email protected]> * Add unit test case Signed-off-by: Matt Lord <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]>

Signed-off-by: Shlomi Noach <[email protected]>

) * Adding a test that validates in-order completion (currently fails because feature is unimplemented) Signed-off-by: Shlomi Noach <[email protected]> * Online DDL: --in-order-completion ddl strategy and logic Signed-off-by: Shlomi Noach <[email protected]> * additional test for --in-order-completion Signed-off-by: Shlomi Noach <[email protected]> * another test for --in-order-completion Signed-off-by: Shlomi Noach <[email protected]> * release notes Signed-off-by: Shlomi Noach <[email protected]> * typo Signed-off-by: Shlomi Noach <[email protected]> * actually checking for completion...! Signed-off-by: Shlomi Noach <[email protected]> * completed_timestamp modified to timestamp(6) Signed-off-by: Shlomi Noach <[email protected]> * Update doc/releasenotes/16_0_0_release_notes.md Co-authored-by: Deepthi Sigireddi <[email protected]> Signed-off-by: Shlomi Noach <[email protected]> * Update doc/releasenotes/16_0_0_release_notes.md Co-authored-by: Deepthi Sigireddi <[email protected]> Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: Deepthi Sigireddi <[email protected]>

…g for existing migration (vitessio#12169) * OnlineDDL: avoid schema_migrations AUTO_INCREMENT gaps by pre-checking for existing migration Signed-off-by: Shlomi Noach <[email protected]> * another refactor: extracted submitCallbackIfNonConflicting(), and the logic applies both to migration submission as well as RetryMigration() Signed-off-by: Shlomi Noach <[email protected]> * ValidateSequentialMigrationIDs Signed-off-by: Shlomi Noach <[email protected]> * refactor test location Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]>

…let init replacing the withDDL-based approach (vitessio#11520) * Add sidecardb module based schema init. Remove metatables. Conditionally disable withddl/health streamer schema init. Fix tests as needed. Signed-off-by: Rohit Nayak <[email protected]> * Implement review comments Signed-off-by: Rohit Nayak <[email protected]> * update to column type Signed-off-by: Shlomi Noach <[email protected]> * Fix bug where we were using _vt before creating it. Added e2e test to CI Signed-off-by: Rohit Nayak <[email protected]> * Reinstate creating vtdatabase optionally Signed-off-by: Rohit Nayak <[email protected]> * Address review comments Signed-off-by: Rohit Nayak <[email protected]> * Fix missed function rename Signed-off-by: Rohit Nayak <[email protected]> * Use schemadiff's new ignore charset/collate hints Signed-off-by: Rohit Nayak <[email protected]> * Add comments to schema files. Normalize schema while reading from file to get rid of the comments and make related changes to tests Signed-off-by: Rohit Nayak <[email protected]> * Refactor e2e test Signed-off-by: Rohit Nayak <[email protected]> * Addressed more review comments Signed-off-by: Rohit Nayak <[email protected]> * Moved sidecar test helpers back to package since it is used in vtexplain Signed-off-by: Rohit Nayak <[email protected]> * Fix issues with setting up fakesqldb test queries Signed-off-by: Rohit Nayak <[email protected]> * Address new review comments Signed-off-by: Rohit Nayak <[email protected]> * Refactor the way we first create tables Signed-off-by: Rohit Nayak <[email protected]> --------- Signed-off-by: Rohit Nayak <[email protected]> Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: Shlomi Noach <[email protected]>

* feat: fail queries from information_schema which aren't querying valid table names Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Andres Taylor <[email protected]> * more columns that can be treated as table and schema names Signed-off-by: Andres Taylor <[email protected]> * renamed test case files Signed-off-by: Andres Taylor <[email protected]> * refactor: clean up code Signed-off-by: Andres Taylor <[email protected]> * clean up types Signed-off-by: Andres Taylor <[email protected]> * test: add query with missing info_schema table Signed-off-by: Andres Taylor <[email protected]> * refactor: clean up method Signed-off-by: Andres Taylor <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: Manan Gupta <[email protected]>

Signed-off-by: Matt Lord <[email protected]>

…itessio#12211)

Signed-off-by: Matt Layher <[email protected]>

* Update dependencies for vtadmin This updates the dependencies and resolves a bunch of Dependabot alerts for vtadmin. Signed-off-by: Dirkjan Bussink <[email protected]> * Update additional dependencies Signed-off-by: Dirkjan Bussink <[email protected]> --------- Signed-off-by: Dirkjan Bussink <[email protected]>

…2149) * feat: remove replication manager Signed-off-by: Manan Gupta <[email protected]> * test: run VTOrc in all e2e tests (some exceptions) Signed-off-by: Manan Gupta <[email protected]> * docs: add summary notes changes Signed-off-by: Manan Gupta <[email protected]> * feat: deprecate disable-replication-manager flag Signed-off-by: Manan Gupta <[email protected]> * test: fix start vtorc function to be idempotent Signed-off-by: Manan Gupta <[email protected]> * docs: fix review comments Signed-off-by: Manan Gupta <[email protected]> * feat: fix port used by vtorc Signed-off-by: Manan Gupta <[email protected]> * test: really fix the ports issue Signed-off-by: Manan Gupta <[email protected]> * test: fix upgrade downgrade test issues with running vtorc Signed-off-by: Manan Gupta <[email protected]> * test: run ISP before starting VTOrc Signed-off-by: Manan Gupta <[email protected]> * feat: fix flakines in throttler test due to vtorc Signed-off-by: Manan Gupta <[email protected]> * test: fix flakiness in vreplication tests Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]>

* Move vtorc from go-sqlite3 to modernc.org/sqlite This moves vtorc from the go-sqlite3 library that uses CGO, to use modernc.org/sqlite which is a pure Go implementation. vtorc is the only component we have to build with CGO but it's causing pain for releases since we need to build it against an old Linux for linking against glibc. Using modernc.org/sqlite allows for using Go only again and makes all Vitess components buildable without CGO. In https://datastation.multiprocess.io/blog/2022-05-12-sqlite-in-go-with-and-without-cgo.html someone ran some basic benchmarks. It shows that the pure Go version can be twice as slow, but the usage of vtorc is very limited and we operate on small datasets, so I think the performance impact purely of a somewhat slower sqlite implementation is negligable. None of this is in a hot query serving path or anything like that, so I have little concern performance wise. Signed-off-by: Dirkjan Bussink <[email protected]> * Fix error handling in RowToArray Signed-off-by: Dirkjan Bussink <[email protected]> --------- Signed-off-by: Dirkjan Bussink <[email protected]>

* Change default MySQL version of lite and base to mysql80 instead of mysql57 Signed-off-by: Florent Poinsard <[email protected]> * Bump MySQL version to 8.0.31 in install_dependencies.sh Signed-off-by: Florent Poinsard <[email protected]> * addition of label to the mysql80 image Signed-off-by: Florent Poinsard <[email protected]> * apply review suggestions Signed-off-by: Florent Poinsard <[email protected]> * bring back mysql80 label Signed-off-by: Florent Poinsard <[email protected]> * add release summary Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]>

…io#12220) The underlying issue has now been addressed in: vitessio#12214 This reverts commit 4b3b37d. Signed-off-by: Matt Lord <[email protected]>

…sio#12222) Signed-off-by: Florent Poinsard <[email protected]>

Signed-off-by: Florent Poinsard <[email protected]>

…cessary GetTablet calls to topo (vitessio#12194) * check filter later in loadTablets. Add tests to confirm expected behavior Signed-off-by: Brian Ramos <[email protected]> * remove unnecessary assignment Co-authored-by: Florent Poinsard <[email protected]> Signed-off-by: Brian Ramos <[email protected]> * add some explanation around TestFilterByKeypsaceSkipsIgnoredTablets Signed-off-by: Brian Ramos <[email protected]> * simplify filter check logic as well as major test cleanup, using testify where possible Signed-off-by: Brian Ramos <[email protected]> --------- Signed-off-by: Brian Ramos <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

* Update Go dependencies This updates the Go dependencies to the latest versions before the Vitess 16 freeze so we can start with an up to date list. Also updates vitess-mixin since Dependabot is reporting a bunch of things on that. Signed-off-by: Dirkjan Bussink <[email protected]> * Fix deprecated sets.String This is now available using generics. Signed-off-by: Dirkjan Bussink <[email protected]> * run make proto Signed-off-by: Florent Poinsard <[email protected]> * fix e2e test expectations Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

Signed-off-by: Matt Lord <[email protected]>

* change vtgate advertised mysql version to 8.0.31 Signed-off-by: Harshit Gangal <[email protected]> * refactor keeping mysql advertised version Signed-off-by: Harshit Gangal <[email protected]> * refactor sqlparser mysql version to use the mysql_server_version default Signed-off-by: Harshit Gangal <[email protected]> * test: update test setup Signed-off-by: Harshit Gangal <[email protected]> * test: updated test help output Signed-off-by: Harshit Gangal <[email protected]> * added release notes Signed-off-by: Harshit Gangal <[email protected]> * feat: remove panic since it is getting triggered from the sidecardb Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]> Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Andres Taylor <[email protected]> Co-authored-by: Florent Poinsard <[email protected]> Co-authored-by: Manan Gupta <[email protected]>

…t views reading from DUAL (vitessio#12189)

* test: show that `autocommit` on lookup vindexes is broken when used after a savepoint is created Signed-off-by: Arthur Schreiber <[email protected]> * test: rework the test case to show that the problem lies with transactions Signed-off-by: Arthur Schreiber <[email protected]> * Correctly handle `autocommit` in the `VIndexLookup` primitive. Signed-off-by: Arthur Schreiber <[email protected]> * Copy the `logging` struct so autocommit queries show up correctly in `vexplain` output. Signed-off-by: Arthur Schreiber <[email protected]> --------- Signed-off-by: Arthur Schreiber <[email protected]>

* docs: add toc to the summary docs Signed-off-by: Manan Gupta <[email protected]> * feat: add link to newly added summary change Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

…o#12273) * Revert default MySQL 80 version * upgrade mysql80 default to 8.0.30 * Add release notes regarding MySQL upgrade path in the vitess-operator * Remove unwanted upgrade path step --------- Signed-off-by: Florent Poinsard <[email protected]>

* Release notes for 16.0.0-rc1 Signed-off-by: Manan Gupta <[email protected]> * Release commit for 16.0.0-rc1 Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

* Download mariadb from vitess-resources * Use proper mariadb version increment in tests * Use 10.10.3 instead of LTS --------- Signed-off-by: Florent Poinsard <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>

…sio#12311) * fix: aggregation coming from right hand side of left join check for null Signed-off-by: Harshit Gangal <[email protected]> * test: added a sum test Signed-off-by: Harshit Gangal <[email protected]> * addressed review comments Signed-off-by: Harshit Gangal <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>

…2281) (vitessio#12308) Signed-off-by: Harshit Gangal <[email protected]>

Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>

Signed-off-by: Harshit Gangal <[email protected]>

…vitessio#12278) * Add lib functions to wait for shard states * Fixup region example too * Address minor review comments * Remove extraneous line change * Refactor to remove duplicated files/code Also address shellcheck warnings. * Fix tests that run in CI * Use more robust location detection * Fix backup tests * Exit on shard healthy failure * Remove unused dups and adjust client_test and Dockerfiles --------- Signed-off-by: Matt Lord <[email protected]>

Signed-off-by: Andres Taylor <[email protected]>

Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: Andres Taylor <[email protected]>

* feat: proto changes to add new rpc Signed-off-by: Harshit Gangal <[email protected]> * feat: vttablet changes in queryservice to implement the new rpc Signed-off-by: Harshit Gangal <[email protected]> * added test on tabletserver Signed-off-by: Harshit Gangal <[email protected]> * feat: use the new schema rpc in vtgate to get updated view definition Signed-off-by: Harshit Gangal <[email protected]> * remove error from getschemaresponse and change the enum name Signed-off-by: Harshit Gangal <[email protected]> * updated proto files for vtadmin Signed-off-by: Harshit Gangal <[email protected]> * fix e2e test Signed-off-by: Harshit Gangal <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]>

…essio#12320) (vitessio#12362) * TableFilter: fix excluded RE listing Signed-off-by: Shlomi Noach <[email protected]> * extract GCTableNameExpression Signed-off-by: Shlomi Noach <[email protected]> * VReplication: exclude GC tables when reading schema Signed-off-by: Shlomi Noach <[email protected]> * wrap schema analyzis errors for better tracability Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: Shlomi Noach <[email protected]>

…vitessio#12381) * Fix SHOW VSCHEMA TABLES tests using v17 vtgate Signed-off-by: Florent Poinsard <[email protected]> * Fix tests expectations Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]>

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.5.0 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](golang/net@v0.5.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) (vitessio#12406) * Allow zero (in) date when setting up internal _vt schema * modify test sto include @@sql_mod query support * Allow zero (in) date when setting up internal _vt schema * modify test sto include @@sql_mod query support * Fix test failures * Fix failing tests. Minor refactor * change sql_mode t omost permissive (empty) * setPermissiveSQLMode * fixes per review * Add missing mock query --------- Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: Shlomi Noach <[email protected]> Co-authored-by: Rohit Nayak <[email protected]>

* Add release notes summary for support views Signed-off-by: Florent Poinsard <[email protected]> * add link to the documentation Signed-off-by: Florent Poinsard <[email protected]> * simplify views release notes Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]>

…#12415) * Examples: correct VTAdmin discovery file path and add check Signed-off-by: Matt Lord <[email protected]> * Remove jq dependency Signed-off-by: Matt Lord <[email protected]> * vtadmin examples scripts hardcode localhost Signed-off-by: Matt Lord <[email protected]> * Fix errant expectation Signed-off-by: Matt Lord <[email protected]> * Adjust healthy shard indicator Signed-off-by: Matt Lord <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]>

This is needed to better support importing from MariaDB into Vitess/MySQL. Signed-off-by: Matt Lord <[email protected]>

…vitessio#12421) * Changed getSchemaRPC to return CreateView instead of SelectStmt Signed-off-by: Florent Poinsard <[email protected]> * test: fix expectation Signed-off-by: Harshit Gangal <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>

* restrict views to single keyspace Signed-off-by: Harshit Gangal <[email protected]> * feat: also create/alter and drop views on MySQL for information-schema-support Signed-off-by: Manan Gupta <[email protected]> * feat: do the DMLs for alter and create of view in a transaction so that they can be rolled back in case of MySQL failure Signed-off-by: Manan Gupta <[email protected]> * ignore view changes by schema tracker in vttablet when views are enabled Signed-off-by: Harshit Gangal <[email protected]> * test: fix test expectation Signed-off-by: Harshit Gangal <[email protected]> * Correct syntax error in defer func of E2E test Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Manan Gupta <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

…ssio#12426) * TableFilter: fix excluded RE listing Signed-off-by: Shlomi Noach <[email protected]> * extract GCTableNameExpression Signed-off-by: Shlomi Noach <[email protected]> * VReplication: exclude GC tables when reading schema Signed-off-by: Shlomi Noach <[email protected]> * wrap schema analyzis errors for better tracability Signed-off-by: Shlomi Noach <[email protected]> * resolve conflict Signed-off-by: Shlomi Noach <[email protected]> * (re)Formalize SQLError in VReplication, add underlying wrap/unwrap functionality Signed-off-by: Shlomi Noach <[email protected]> * update test to match new UnwrapAll() behavior Signed-off-by: Shlomi Noach <[email protected]> * do not unwrap Signed-off-by: Shlomi Noach <[email protected]> * Online DDL: use LastError for retrying vreplication streams Signed-off-by: Shlomi Noach <[email protected]> * differentiate between a temrinally failed workflow and one which 'has error' and can be retried Signed-off-by: Shlomi Noach <[email protected]> * wording Signed-off-by: Shlomi Noach <[email protected]> * simplified hasError() Signed-off-by: Shlomi Noach <[email protected]> * more onlineddl_vrepl tests; use dynamic throttler config; fix wait for vreplication status Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]>

* examples: should use mysql80 property for vitess image Signed-off-by: deepthi <[email protected]> * Use MySQL80 in all examples/operator YAML files Signed-off-by: Florent Poinsard <[email protected]> * feat: fix vtadmin image version Signed-off-by: Manan Gupta <[email protected]> * feat: update release script to update vtadmin image version too Signed-off-by: Manan Gupta <[email protected]> * feat: fix vtop example script to use vtctldclient instead Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: deepthi <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Florent Poinsard <[email protected]> Co-authored-by: Manan Gupta <[email protected]>

…es (vitessio#12436) * schemadiff: AlterTableAlgorithmStratgy Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> * minor rename Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> * Use COPY algorithm while altering sidecardb tables Signed-off-by: Rohit Nayak <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: Shlomi Noach <[email protected]>

Dependabot does pick up these go.mod files but somehow fails to open PRs for them to update things that are vulnerable. So doing it manually here. Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]>

…ssio#12328) (vitessio#12431) * Don't fail on schema init errors Signed-off-by: Rohit Nayak <[email protected]> * Fix debug var attribute name Signed-off-by: Rohit Nayak <[email protected]> * Fix typo in debug var Signed-off-by: Rohit Nayak <[email protected]> * Address review comment Signed-off-by: Rohit Nayak <[email protected]> * Address review comments Signed-off-by: Rohit Nayak <[email protected]> --------- Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: Rohit Nayak <[email protected]>

* GetSchema rpc to streaming api Signed-off-by: Harshit Gangal <[email protected]> * addressed review comment Signed-off-by: Harshit Gangal <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]>

…mple (vitessio#12458) * feat: fix vtctldclient command Signed-off-by: Manan Gupta <[email protected]> * examples: remove enforceSemiSync from operator example Signed-off-by: deepthi <[email protected]> * feat: also update vitess operator version Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: deepthi <[email protected]> Co-authored-by: deepthi <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

* feat: breaking changes should be the first heading Signed-off-by: Manan Gupta <[email protected]> * feat: reorder the breaking changes in order of user impact Signed-off-by: Manan Gupta <[email protected]> * feat: VTOrc becoming mandatory is important Signed-off-by: Manan Gupta <[email protected]> * Reorganize the flag deletions and deprecation announcements Signed-off-by: Florent Poinsard <[email protected]> * Fix various typo and add vtorc links Signed-off-by: Florent Poinsard <[email protected]> * Upgrading to this release with vitess-operator Signed-off-by: Florent Poinsard <[email protected]> * Fix various typo Signed-off-by: Florent Poinsard <[email protected]> * Link to PRs in major changes Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

…io#12468) * fix: scalar aggregation truncation Signed-off-by: Harshit Gangal <[email protected]> * test: added scalar aggr engine unit test Signed-off-by: Harshit Gangal <[email protected]> * remove onecase change Signed-off-by: Harshit Gangal <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]>

Signed-off-by: Andy Lim <[email protected]> Signed-off-by: deepthi <[email protected]> Co-authored-by: Andy Lim <[email protected]>

…itessio#12475) Signed-off-by: deepthi <[email protected]>

* Upgrade release-16.0 to go1.19.6 Signed-off-by: Florent Poinsard <[email protected]> * upgrade to 1.20.1 Signed-off-by: Florent Poinsard <[email protected]> * bump the golangci-lint version Signed-off-by: Florent Poinsard <[email protected]> * Apply linter suggestions Signed-off-by: Florent Poinsard <[email protected]> * Apply linter suggestions Signed-off-by: Florent Poinsard <[email protected]> * fix TestTLSClientVerifyIdentity Signed-off-by: Florent Poinsard <[email protected]> * Switch to using new Go 1.19 CRL parser (vitessio#12315) `x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList` instead which is new in Go 1.19. Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> * Skip TestFuzz for now Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]>

…sio#12484) * test: add failing test for a query in an unsharded keyspace using a derived table and reference table Signed-off-by: Manan Gupta <[email protected]> * feat: fix logic to check if a single unsharded keyspace is used Signed-off-by: Manan Gupta <[email protected]> * feat: fix test output Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]>

…io#12503) Signed-off-by: Matt Lord <[email protected]> Co-authored-by: Matt Lord <[email protected]>

* Release notes for 16.0.0 Signed-off-by: Manan Gupta <[email protected]> * Release commit for 16.0.0 Signed-off-by: Manan Gupta <[email protected]> * Minor tweaks after review Signed-off-by: Matt Lord <[email protected]> * Clarify user vs developer for sidecardb schema Signed-off-by: Matt Lord <[email protected]> * feat: update the summary doc too for future patch releases Signed-off-by: Manan Gupta <[email protected]> * feat: update release notes and changelog after recent changes Signed-off-by: Manan Gupta <[email protected]> * feat: fix summary file to add examples of label change Signed-off-by: Manan Gupta <[email protected]> * feat: update release notes and changelog Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Matt Lord <[email protected]> Co-authored-by: Matt Lord <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

Signed-off-by: Florent Poinsard <[email protected]>

…nd (vitessio#12481) (vitessio#12532) * Add a Run func to `vtctldclient`'s Root command to return an error on unknown command Closes vitessio#12480. * Add test * flags test data --------- Signed-off-by: Andrew Mason <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

* Improve release process post `v16.0.0 GA` code freeze (vitessio#12487) * Update the release instructions document with pre-requisites for release team Signed-off-by: Florent Poinsard <[email protected]> * Add Do Not Merge to release Pull Request upon creation Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> * Block merge if the `Do Not Merge` label is set (vitessio#12489) * Block Merge if the label is set Signed-off-by: Florent Poinsard <[email protected]> * fix echo syntax Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]>

* Online DDL: enforce ALGORITHM=COPY on shadow table Signed-off-by: Shlomi Noach <[email protected]> * unit tests Signed-off-by: Shlomi Noach <[email protected]> * resolve conflict Signed-off-by: Shlomi Noach <[email protected]> * algorithm format Signed-off-by: Shlomi Noach <[email protected]> * revert change to sql.y Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]>

…` Docker build (vitessio#12530) (vitessio#12561) * Fix dubious ownership of git directory in vitess/base Docker build Signed-off-by: Florent Poinsard <[email protected]> * Use consistent method to copy and build vitess between base and lite Signed-off-by: Florent Poinsard <[email protected]> * fix all base Dockerfiles Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

…#12555) (vitessio#12556) * collations: fix sorting in UCA900 collations When using the fast iterator to _compare_ two strings with an UCA collation, we need to keep in mind that the weights in the collation are in BIG ENDIAN (this is the output format for the weight strings, so we store the weights this way), so comparing them directly will not result in the proper collation order. They need to be byte-swapped before they can be compared with an arithmetic operation! Signed-off-by: Vicent Marti <[email protected]> * collations: comment Signed-off-by: Vicent Marti <[email protected]> --------- Signed-off-by: Vicent Marti <[email protected]> Co-authored-by: Vicent Marti <[email protected]>

…vitessio#12520) (vitessio#12576) * Store throttler config in global Keyspace record Signed-off-by: Matt Lord <[email protected]> * Fix unit test after ThrottlerConfig in Keyspace Signed-off-by: Matt Lord <[email protected]> * Apply changes lost in cherry picks Signed-off-by: Matt Lord <[email protected]> * Always wait for a status before the final check. We should not ever make an assumption about how quickly an operation will take. Signed-off-by: Matt Lord <[email protected]> * Propagate PartialResult and other errs back to client Signed-off-by: Matt Lord <[email protected]> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <[email protected]> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <[email protected]> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <[email protected]> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <[email protected]> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <[email protected]> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <[email protected]> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <[email protected]> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <[email protected]> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <[email protected]> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <[email protected]> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <[email protected]> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <[email protected]> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <[email protected]> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <[email protected]> * Update go/test/endtoend/onlineddl/vtctlutil.go Signed-off-by: Shlomi Noach <[email protected]> * Update go/test/endtoend/onlineddl/vtgate_util.go Signed-off-by: Shlomi Noach <[email protected]> * fix grammar Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: Matt Lord <[email protected]> Co-authored-by: Shlomi Noach <[email protected]>

…sio#12560) (vitessio#12581) * Examples: wait for shard's vreplication engine to open * Minor comment changes --------- Signed-off-by: Matt Lord <[email protected]>

…12589) Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: Shlomi Noach <[email protected]>

…runners (vitessio#12583) (vitessio#12588) * CI: extend timeouts in onlineddl_vrepl due to slow CI runners Signed-off-by: Shlomi Noach <[email protected]> * increase even further Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: Shlomi Noach <[email protected]>

* Purge logs without panicking * Purge logs without panicking * try moving the goroutine to the func itself --------- Signed-off-by: Andrew Mason <[email protected]>

…essio#12630) * Add signed and unsigned integer types to forked ason library to fix issue of integers being parsed as float64 by the source binlog parser. This results in larger integers being stored as floats on the target and sent with scientific notation in vstream events. Signed-off-by: Rohit Nayak <[email protected]> * Use go.mod reference to the ajson module to make it easier to switch to the upstream module once changes are made there Signed-off-by: Rohit Nayak <[email protected]> --------- Signed-off-by: Rohit Nayak <[email protected]>

…og` (vitessio#12566) (vitessio#12660) * Re-organize the `releasenotes` directory into `changelog` (vitessio#12566) * Move all release related documents to ./release and add tool to generate READMEs Signed-off-by: Florent Poinsard <[email protected]> * Addition of the release.go file Signed-off-by: Florent Poinsard <[email protected]> * simplify release.go Signed-off-by: Florent Poinsard <[email protected]> * generate the release notes in the proper place Signed-off-by: Florent Poinsard <[email protected]> * modify previous mentions of docs/releasenotes Signed-off-by: Florent Poinsard <[email protected]> * re-add v17.0.0 summary Signed-off-by: Florent Poinsard <[email protected]> * add new release tool to release instruction and ci Signed-off-by: Florent Poinsard <[email protected]> * apply review suggestions Signed-off-by: Florent Poinsard <[email protected]> * simplify release notes document path Signed-off-by: Florent Poinsard <[email protected]> * Apply review suggestions and fix team files Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> * update the changelog dir and release_notes_label workflow Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]>

vitessio#12671) Signed-off-by: Florent Poinsard <[email protected]>

…le (vitessio#12607) (vitessio#12648) * Fix random aggregation to not select Null column * stop pushing down projections that should be evaluated at the vtgate level * undo changes to AggregateRandom * clean up code * fix executor test mock --------- Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: Andres Taylor <[email protected]>

…ma (vitessio#12641) (vitessio#12664) * Mysqld.GetSchema: tolerate tables being dropped while inspecting schema * lack of primary key columns in STATISTICS does not mean table is dropped. It can also mean the table does not have PRIMARY KEY * populate validTds rather than rely on nil hints * re-introdce earlier check * use validTds, sync * due to many tests consistently failing, trying a different approach: we keep the table, but with empty column/key/fields info * grammar --------- Signed-off-by: Shlomi Noach <[email protected]>

…io#12670) * Always add column in the derived operator * Fix plan tests expectations --------- Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: Andres Taylor <[email protected]>

…tessio#12534) (vitessio#12691) * feat: fix initialization code to also stop replication * feat: fix tests expectations * feat: fix wrangler tests --------- Signed-off-by: Manan Gupta <[email protected]>

…#12698) * [planner bugfix] add expressions to HAVING When a predicate contains aggregation, it should not be added to the WHERE clause. It should go to the * update test expecteations --------- Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: Andres Taylor <[email protected]>

@mattlord

…ssio#12709) * Auto upgrade the Golang version (vitessio#12585) * initial addition of the go_upgrade tool to detect and bump the golang version Signed-off-by: Florent Poinsard <[email protected]> * update go.mod automatically Signed-off-by: Florent Poinsard <[email protected]> * fix isSameMajor version issue Signed-off-by: Florent Poinsard <[email protected]> * update the bootstrap version automatically Signed-off-by: Florent Poinsard <[email protected]> * update the bootstrap docker image changelog Signed-off-by: Florent Poinsard <[email protected]> * uncomment code Signed-off-by: Florent Poinsard <[email protected]> * addition of workflow Signed-off-by: Florent Poinsard <[email protected]> * addition of base to create-pull-request Signed-off-by: Florent Poinsard <[email protected]> * test create PR alternative Signed-off-by: Florent Poinsard <[email protected]> * add flags and getter methods Signed-off-by: Florent Poinsard <[email protected]> * better PR message Signed-off-by: Florent Poinsard <[email protected]> * fix no-workflow-update flag and better PR body msg Signed-off-by: Florent Poinsard <[email protected]> * fix PR title, branch and body format Signed-off-by: Florent Poinsard <[email protected]> * test matrix and pwd path Signed-off-by: Florent Poinsard <[email protected]> * enhanced matrix Signed-off-by: Florent Poinsard <[email protected]> * update_workflows option Signed-off-by: Florent Poinsard <[email protected]> * update workflows independently Signed-off-by: Florent Poinsard <[email protected]> * test without matrix Signed-off-by: Florent Poinsard <[email protected]> * Add docs to go_upgrade and re-add matrix to the workflow Signed-off-by: Florent Poinsard <[email protected]> * support major version upgrade Signed-off-by: Florent Poinsard <[email protected]> * do not update bootstrap version if they are the same Signed-off-by: Florent Poinsard <[email protected]> * migrate to cobra instead of pflags Signed-off-by: Florent Poinsard <[email protected]> * remove redundant comment Signed-off-by: Florent Poinsard <[email protected]> * safety net around replaceGoVersionInCodebase to avoid unrequired upgrade Signed-off-by: Florent Poinsard <[email protected]> * Remove double negation in workflowUpdate flag Signed-off-by: Florent Poinsard <[email protected]> * Use regexp instead of mere string comparison Signed-off-by: Florent Poinsard <[email protected]> * Proper regexp for every string comparison Signed-off-by: Florent Poinsard <[email protected]> * use better regex Signed-off-by: Florent Poinsard <[email protected]> * remove useless flag and improve the auto-PR body description Signed-off-by: Florent Poinsard <[email protected]> * add note in the tool usage to run the tool at the root of the repo Signed-off-by: Florent Poinsard <[email protected]> * add comment in .github/workflows/update_golang_version.yml Signed-off-by: Florent Poinsard <[email protected]> * Apply @mattlord code suggestion Signed-off-by: Florent Poinsard <[email protected]> * replace usages of old filename Signed-off-by: Florent Poinsard <[email protected]> * Apply suggestions from code review Co-authored-by: Matt Lord <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Matt Lord <[email protected]> * Fix regexp Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Matt Lord <[email protected]>

…12721) * feat: reenable launchable for unit_tests * feat: only run CI on PRs against main * feat: use base_ref instead of ref --------- Signed-off-by: Manan Gupta <[email protected]>

…itessio#12704) (vitessio#12725) Signed-off-by: Andres Taylor <[email protected]>

…er `65,528` parameters (vitessio#12614) (vitessio#12627) * fix type conversion in query.go for the bitMap size Signed-off-by: Florent Poinsard <[email protected]> * enhance the TestHighNumberOfParams test Signed-off-by: Florent Poinsard <[email protected]> * fix test comment Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

Signed-off-by: Hormoz Kheradmand <[email protected]> Co-authored-by: Hormoz Kheradmand <[email protected]>

* bump go version to go1.20.2 Signed-off-by: GitHub <[email protected]> * Update the golang version to 1.20.2 Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: GitHub <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: frouioui <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

) Signed-off-by: Rameez Sajwani <[email protected]>

* remove unnecessary vtorc process * Adding vtorc disabling at right place * Adding comments --------- Signed-off-by: Rameez Sajwani <[email protected]>

…io#12502) (vitessio#12740) * Use new healthy shard check in vreplication e2e tests This is needed because checking that there's a primary tablet for the shard in vtgate's healtcheck is no longer a reliable indicator that the shard has a healthy serving primary, because now a primary needs to initialize its sidecar database and wait for that to replicate via semi-sync before it becomes serving and can proceed to perform normal functions. So this delay could cause test flakiness if you required a healthy shard before continuing with the test. * Try to address unit test race flakes around log size They looked like this: WARNING: DATA RACE Write at 0x000005bf9b60 by goroutine 27141: github.com/spf13/pflag.newUint64Value() /home/runner/go/pkg/mod/github.com/spf13/[email protected]/uint64.go:9 +0x5a github.com/spf13/pflag.(*FlagSet).Uint64Var() /home/runner/go/pkg/mod/github.com/spf13/[email protected]/uint64.go:45 +0x55 vitess.io/vitess/go/vt/log.RegisterFlags() /home/runner/work/vitess/vitess/go/vt/log/log.go:81 +0x64 vitess.io/vitess/go/vt/servenv.GetFlagSetFor() /home/runner/work/vitess/vitess/go/vt/servenv/servenv.go:347 +0x183 vitess.io/vitess/go/vt/servenv.ParseFlags() /home/runner/work/vitess/vitess/go/vt/servenv/servenv.go:326 +0x49 ... Previous read at 0x000005bf9b60 by goroutine 27136: 1744 github.com/golang/glog.(*syncBuffer).Write() ... And they most often occurred in the wrangler unit tests, which makes sense because it creates a log of loggers. * Revert "Try to address unit test race flakes around log size" This reverts commit 51992b8. * Use external cluster vtctld in TestMigrate * Use subshell vs command output interpolation * Ingnore any config files in mysql alias --------- Signed-off-by: Matt Lord <[email protected]> Co-authored-by: Matt Lord <[email protected]>

* planner: fix predicate simplifier * predicate rewriting: add debug logging * add debug logging to make the code easier to understand * address review feedback * Update go/vt/vtgate/planbuilder/predicate_rewrite_test.go Nicer panic message --------- Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Andres Taylor <[email protected]>

…ce=innodb_system are included in the schema (vitessio#12672) (vitessio#12735) * Use a left join to make sure that tables with tablespace=innodb_system are not skipped when loading the schema (fixes vitessio#12669) Signed-off-by: Oleksiy Kovyrin <[email protected]> * Set tablespace on a test table to see if it breaks vstreamer Signed-off-by: Oleksiy Kovyrin <[email protected]> --------- Signed-off-by: Oleksiy Kovyrin <[email protected]> Co-authored-by: Oleksiy Kovyrin <[email protected]>

… reader. (vitessio#12683) (vitessio#12741) * Reset the current lag when closing the replication lag reader. Signed-off-by: Johan Stenberg <[email protected]> * Fix tests. Signed-off-by: Johan Stenberg <[email protected]> --------- Signed-off-by: Johan Stenberg <[email protected]> Co-authored-by: Johan Stenberg <[email protected]>

…12546 (vitessio#12745) * Flakes: Address Common Unit Test Races (vitessio#12546) * Deflake unit race tests Signed-off-by: Matt Lord <[email protected]> * Try to address glog.MaxSize race Signed-off-by: Matt Lord <[email protected]> * Test w/o using literal copy of glog.MaxSize value in CI Signed-off-by: Matt Lord <[email protected]> * Make the dialer names truly unique Signed-off-by: Matt Lord <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]> * Use atomic.Bool for fakesqldb behavior flags (vitessio#12603) Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Max Englander <[email protected]> Co-authored-by: Matt Lord <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Max Englander <[email protected]> Co-authored-by: Matt Lord <[email protected]> Co-authored-by: Max Englander <[email protected]>

…itessio#12748) Signed-off-by: Hormoz Kheradmand <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Hormoz Kheradmand <[email protected]>

Signed-off-by: Florent Poinsard <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

…ce names (vitessio#12732) (vitessio#12771) * Update topo {Get,Create}Keyspace to prevent invalid keyspace names (vitessio#12732) * Update topo {Get,Create}Keyspace to prevent invalid keyspace names Signed-off-by: Andrew Mason <[email protected]> * embarrassing Signed-off-by: Andrew Mason <[email protected]> * docs, release notes Signed-off-by: Andrew Mason <[email protected]> * only validate, do not correct Signed-off-by: Andrew Mason <[email protected]> * broader restrictions via allow-list Signed-off-by: Andrew Mason <[email protected]> * Revert "broader restrictions via allow-list" This reverts commit 5354d4f. Signed-off-by: Andrew Mason <[email protected]> * tighten up release notes scope Signed-off-by: Andrew Mason <[email protected]> * Update go/vt/topo/keyspace.go Co-authored-by: Florent Poinsard <[email protected]> Signed-off-by: Andrew Mason <[email protected]> --------- Signed-off-by: Andrew Mason <[email protected]> Co-authored-by: Florent Poinsard <[email protected]> * update notes and comments Signed-off-by: Andrew Mason <[email protected]> --------- Signed-off-by: Andrew Mason <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

* Release notes for 16.0.1 Signed-off-by: Manan Gupta <[email protected]> * Release commit for 16.0.1 Signed-off-by: Manan Gupta <[email protected]> * feat: fix release notes folder Signed-off-by: Manan Gupta <[email protected]> * rebase after 12732 Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

…12775) Signed-off-by: Florent Poinsard <[email protected]>

…e Tests (vitessio#12791) * Throttler: Expose Tablet's Config & Leverage to Deflake Tests (vitessio#12737) * Flakes: effectively disable vtorc for deterministic behavior For example, we stop replication, wait a few seconds, then expect there to be lag. But vtorc could repair replication during that wait and then the lag is gone. Signed-off-by: Matt Lord <[email protected]> * Wait for the throttler to be up and running everywhere Signed-off-by: Matt Lord <[email protected]> * Expose tablet's throttler config and leverage to deflake tests Signed-off-by: Matt Lord <[email protected]> * Apply various corrections Signed-off-by: Matt Lord <[email protected]> * Be more explicit about VTOrc behavior changes Signed-off-by: Matt Lord <[email protected]> * Note received throttler response when it is unexpected Signed-off-by: Matt Lord <[email protected]> * Fixes from local testing Signed-off-by: Matt Lord <[email protected]> * Nits from self review Signed-off-by: Matt Lord <[email protected]> * Use assert.Equalf on failed assertions Signed-off-by: Matt Lord <[email protected]> * Ummm, duh. Signed-off-by: Matt Lord <[email protected]> * Try to get rid of last bit of flakiness Which seemed to revolve around NOT sleeping long enough after starting all the sleep queries. Signed-off-by: Matt Lord <[email protected]> * Nits from self review Signed-off-by: Matt Lord <[email protected]> * Address review comments Signed-off-by: Matt Lord <[email protected]> * Adjust test for behavior and comment it And adjust timing Signed-off-by: Matt Lord <[email protected]> * Align both stale hearbeat checks Signed-off-by: Matt Lord <[email protected]> * Remove no longer needed flag This is because enabling heartbeats with --heartbeat_enable also results in the replication reporter being enabled: https://github.com/vitessio/vitess/blob/3d9ef871e42bd20a60ec95997c97ecf0694c1e78/go/vt/vttablet/tabletserver/tabletenv/config.go#L235-L237 Signed-off-by: Matt Lord <[email protected]> * Correct comment Signed-off-by: Matt Lord <[email protected]> * Correct comment part II: electric boogaloo Signed-off-by: Matt Lord <[email protected]> * Revert one other minor unnecessary change. Signed-off-by: Matt Lord <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]> * Post cherry-pick fixup Signed-off-by: Matt Lord <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]>

…essio#12807) * Automatically add milestone to new Pull Request * Run the workflow on pull_request_target event * Use gh pr edit to add milestone * Use bash instead of go script --------- Signed-off-by: Florent Poinsard <[email protected]>

…tessio#12769) (vitessio#12796) * Fix incorrect path during release notes generation Signed-off-by: Florent Poinsard <[email protected]> * Apply review suggestion Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: Shlomi Noach <[email protected]>

…itessio#12818) Signed-off-by: Andrew Mason <[email protected]> Co-authored-by: Andrew Mason <[email protected]>

…2822) We have tests like `TestMoveTablesV2` which end up reading and writing queries concurrently. This causes the race detector to appropriately trigger and detect issues here. Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]>

)

…12838) (vitessio#12848) * fix float issue with bootstrap version increment Signed-off-by: Florent Poinsard <[email protected]> * handle case where there are no minor bootstrap version Signed-off-by: Florent Poinsard <[email protected]> * avoid re-creating Pull Requests Signed-off-by: Florent Poinsard <[email protected]> * remove parse float Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

…tessio#12810) (vitessio#12823) * fixes vitessio#12798 * [planbuilder bugfix] don't push down predicates that need to be aggregated at the vtgate level --------- Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Andres Taylor <[email protected]>

…itessio#12854) Signed-off-by: Florent Poinsard <[email protected]>

* bump go version to go1.20.3 Signed-off-by: GitHub <[email protected]> * modify the github workflows and fix the bootstrap version increment Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: GitHub <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: frouioui <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

) (vitessio#12812) * Do not fail build on incorrect Go version Signed-off-by: Florent Poinsard <[email protected]> * Remove misleading message in build.env Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

…#12843 (vitessio#12858) * [topo] Disallow the slash character in shard names (vitessio#12843) * Disallow the slash character in shard names Fixes vitessio#12842. Signed-off-by: Andrew Mason <[email protected]> * add release note Signed-off-by: Andrew Mason <[email protected]> * Update go/vt/topo/shard.go Co-authored-by: Deepthi Sigireddi <[email protected]> Signed-off-by: Andrew Mason <[email protected]> * Update changelog/17.0/17.0.0/summary.md Co-authored-by: Deepthi Sigireddi <[email protected]> Signed-off-by: Andrew Mason <[email protected]> --------- Signed-off-by: Andrew Mason <[email protected]> Signed-off-by: Andrew Mason <[email protected]> Co-authored-by: Deepthi Sigireddi <[email protected]> * add changelog stub Signed-off-by: Andrew Mason <[email protected]> * fix version name Signed-off-by: Andrew Mason <[email protected]> --------- Signed-off-by: Andrew Mason <[email protected]> Signed-off-by: Andrew Mason <[email protected]> Co-authored-by: Deepthi Sigireddi <[email protected]>

…de a subquery (vitessio#12891) * planner fix: scoping rules for JOIN ON expression inside a subquery (vitessio#12881) * fix: scoping rules for on clause expression inside a subquery Signed-off-by: Harshit Gangal <[email protected]> * find the parent scope of the statement in on clause Signed-off-by: harshit-gangal <[email protected]> * addressed review comments Signed-off-by: harshit-gangal <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]> Signed-off-by: harshit-gangal <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> * Fix plan test expectation for v3 Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]> Signed-off-by: harshit-gangal <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>

Signed-off-by: Florent Poinsard <[email protected]>

…nnection (vitessio#12877) Signed-off-by: Harshit Gangal <[email protected]>

Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>

…o#12974) Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>

… Version (vitessio#12957) (vitessio#12962) * update v16 release notes about VTGate Advertised MySQL Version Signed-off-by: yoheimuta <[email protected]> * Update changelog/16.0/16.0.0/release_notes.md Signed-off-by: Florent Poinsard <[email protected]> * Update changelog/16.0/16.0.0/summary.md Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: yoheimuta <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: yoheimuta <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

…itessio#13033) Signed-off-by: Andres Taylor <[email protected]>

…ID to user from static authentication context (vitessio#12961) (vitessio#12984) * Disables automatically setting immediateCallerID to User from Static authentication Context Signed-off-by: Phani Raj <[email protected]> * Set effectiveCallerID based on these rules The client cert common name (if using mTLS) The effective caller id (if --grpc_use_effective_callerid=true) The static auth username (if --mysql_use_static_auth_username=true) Signed-off-by: Phani Raj <[email protected]> * update vtgate help text fixture Signed-off-by: Phani Raj <[email protected]> * Add new test to vtgate_shard_heavy test run Signed-off-by: Phani Raj <[email protected]> * Run EffectiveCallerID tests in vtgate_general_heavy Signed-off-by: Phani Raj <[email protected]> * feat: use DialWithOpts in release-16.0 since Dial doesn't exist Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: Phani Raj <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Phani Raj <[email protected]> Co-authored-by: Manan Gupta <[email protected]>

* feat: add summary docs changes Signed-off-by: Manan Gupta <[email protected]> * Code freeze of release-16.0 Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]>

* Release notes for 16.0.2 Signed-off-by: Manan Gupta <[email protected]> * Release commit for 16.0.2 Signed-off-by: Manan Gupta <[email protected]> * regenerate the changelog Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

* bump go version to go1.20.4 Signed-off-by: GitHub <[email protected]> * upgrade the workflows with newer golang version Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: GitHub <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: frouioui <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

…initialization (vitessio#13080) (vitessio#13087) * feat: fix the resilient query code to work better right after it has started Signed-off-by: Manan Gupta <[email protected]> * feat: return after erroring out in TimeoutAction Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>

Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

…le entries on Cancel (vitessio#13146) (vitessio#13155) * Don't delete vschema table entries that VReplication does not create Signed-off-by: Matt Lord <[email protected]> * Update unit test accordingly Signed-off-by: Matt Lord <[email protected]> * Improve comment Signed-off-by: Matt Lord <[email protected]> * Adjust workflow complete unit test as well Signed-off-by: Matt Lord <[email protected]> * Limit this behavior change to Cancel Signed-off-by: Matt Lord <[email protected]> * Improve comment Signed-off-by: Matt Lord <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]> Co-authored-by: Matt Lord <[email protected]>

… on error (vitessio#13193) * ReserveBeginExecute to return transaction id even if reserver id is not present when there is an error Signed-off-by: Harshit Gangal <[email protected]> * enabled settings pool for e2e test Signed-off-by: Harshit Gangal <[email protected]> --------- Signed-off-by: Harshit Gangal <[email protected]>

…for Cancel action (vitessio#13171) (vitessio#13194) * Pass on keep_routing_rules flag value for Cancel action Signed-off-by: Matt Lord <[email protected]> * Add e2e test for Cancel --keep_routing_rules Signed-off-by: Matt Lord <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]> Co-authored-by: Matt Lord <[email protected]>

* test: add health-streamer test Signed-off-by: Manan Gupta <[email protected]> * feat: fix test Signed-off-by: Manan Gupta <[email protected]> * feat: fix health streamer Signed-off-by: Manan Gupta <[email protected]> * feat: fix health streamer tests Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]>

vitessio#13204) * Upgrade mysqld memory limits to 1024Mi Signed-off-by: Vinícius do Carmo <[email protected]> * Close vitessio#13118 Signed-off-by: Vinícius do Carmo <[email protected]> --------- Signed-off-by: Vinícius do Carmo <[email protected]> Co-authored-by: Vinícius do Carmo <[email protected]>

…e a value (vitessio#13148) (vitessio#13154) Signed-off-by: Andres Taylor <[email protected]>

* skip test assertion if binary above 16 Signed-off-by: Florent Poinsard <[email protected]> * Add result filtering for warning for vtconfig error Signed-off-by: Florent Poinsard <[email protected]> * Revert change Signed-off-by: Florent Poinsard <[email protected]> * filter result for warning Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]>

* bump go version to go1.20.5 Signed-off-by: GitHub <[email protected]> * Update github actions workflow with go1.20.5 Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: GitHub <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: frouioui <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

) (vitessio#13166)

…13255) (vitessio#13282) * Fix VDiff2 DeleteByUUID Query It was incorrect and thus deleting every row in the vdiff table. IIRC, this was a mistake on my part as I was first using a WHERE based query and then had to move to LEFT JOIN usage as there may not always be vdiff_table records. When doing so, however, I left the last AND clause in place when it should have become the sole predicate in a new WHERE clause after the LEFT JOIN condition. Signed-off-by: Matt Lord <[email protected]> * Add unit test as well Signed-off-by: Matt Lord <[email protected]> * Minor changes after review Signed-off-by: Matt Lord <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]> Co-authored-by: Matt Lord <[email protected]>

…gregation random` (vitessio#13330) (vitessio#13334) * fixed unknown aggregation random bug Signed-off-by: Arvind Murty <[email protected]> * fixed schema.sql formatting Signed-off-by: Arvind Murty <[email protected]> --------- Signed-off-by: Arvind Murty <[email protected]> Co-authored-by: Arvind Murty <[email protected]>

…itessio#13312) (vitessio#13323) * mysqlctl: Correctly encode database and table names These need to be escaped as SQL strings for queries against the `information_schema` or otherwise any names that need quotes will break. Signed-off-by: Dirkjan Bussink <[email protected]> * Trigger CI Signed-off-by: Dirkjan Bussink <[email protected]> --------- Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Andrew Mason <[email protected]> Co-authored-by: Andrew Mason <[email protected]>

… with a flag (vitessio#13316) * Set the number of threads for release notes generation with a flag (vitessio#13273) * Set the number of threads for release notes generation by a flag Signed-off-by: Florent Poinsard <[email protected]> * Add the flag to the release instructions and remove the make commande for release notes Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> * remove os.Exit (vitessio#13310) Signed-off-by: Florent Poinsard <[email protected]> * remove unwanted makefile rule Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]>

…ation source (vitessio#13377) (vitessio#13392)

…essio#13375) (vitessio#13389) * BaseShowTablesWithSizes: optimize MySQL 8.0 query Signed-off-by: Shlomi Noach <[email protected]> * adapt regular expression Signed-off-by: Shlomi Noach <[email protected]> * adapt regular expression, 2 Signed-off-by: Shlomi Noach <[email protected]> * refactored query again to combat the many unit test query format assumptions Signed-off-by: Shlomi Noach <[email protected]> * use t.table_schema in GROUP BY. Although not strictly necessary this may be faster Signed-off-by: Shlomi Noach <[email protected]> * Support views in BaseShowTablesWithSizes for MySQL 8.0 (vitessio#13394) * Support views in BaseShowTablesWithSizes for MySQL 8.0 Signed-off-by: Shlomi Noach <[email protected]> * added test Signed-off-by: Shlomi Noach <[email protected]> * fixed test Signed-off-by: Shlomi Noach <[email protected]> * schema tracker: use null safe comparison Signed-off-by: Andres Taylor <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: Andres Taylor <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: Shlomi Noach <[email protected]> Co-authored-by: Andres Taylor <[email protected]>

…13396) (vitessio#13402) Signed-off-by: Manan Gupta <[email protected]>

… (vitessio#13409) * test: deflake TestQueryTimeoutWithDual test Signed-off-by: Manan Gupta <[email protected]> * empty commit to kick CI Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>

…semi-sync ACKs while upgrading (vitessio#13411) (vitessio#13441)

…io#13421) (vitessio#13424) * ignore views load error * added unit test --------- Signed-off-by: Harshit Gangal <[email protected]>

Signed-off-by: Shlomi Noach <[email protected]>

vitessio#13462)

Signed-off-by: Tim Vaillancourt <[email protected]>

…ease-16.0 [release-16.0] `examples/compose`: fix `consul:latest` error w/`docker-compose up -d` (vitessio#13468)

…itessio#13469) (vitessio#13500) Fix `TestGatewayBufferingWhileReparenting` flakiness (vitessio#13469)

…io#13528) Signed-off-by: Manan Gupta <[email protected]>

…itessio#13548) (vitessio#13549) Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…db.sql` (vitessio#13525) Signed-off-by: Manan Gupta <[email protected]>

…essio#13126) Co-authored-by: Florent Poinsard <[email protected]>

…ssio#13571) Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…saction (vitessio#13547) (vitessio#13580) Signed-off-by: Matt Lord <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…13590) (vitessio#13593) Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>

) (vitessio#13585) Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>

…itessio#13576) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Dirkjan Bussink <[email protected]>

…ones (vitessio#13398) (vitessio#13621) Signed-off-by: Florent Poinsard <[email protected]>

…kup restores (vitessio#13557) (vitessio#13634) Signed-off-by: Priya Bibra <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…itessio#13523) (vitessio#13607) Co-authored-by: Harshit Gangal <[email protected]>

…#13618) (vitessio#13645) Co-authored-by: Florent Poinsard <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

…sue (vitessio#13736) Signed-off-by: Shlomi Noach <[email protected]>

…o#13732)

…vitessio#13759) Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Shlomi Noach <[email protected]>

Signed-off-by: Rohit Nayak <[email protected]>

…ob Service (vitessio#13770) (vitessio#13774) Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Shlomi Noach <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>

…own within CI (vitessio#13793) (vitessio#13797) Signed-off-by: Matt Lord <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…from schema tracker (vitessio#13673) (vitessio#13795) Signed-off-by: Matt Lord <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

…essio#13805) Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

vitessio#13813) (vitessio#13819) Signed-off-by: Andrew Mason <[email protected]> Co-authored-by: Andrew Mason <[email protected]>

…ation e2e test (vitessio#13803) (vitessio#13821) Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…Diff2 Progress command is in the future. (vitessio#13804) (vitessio#13816) Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…uld not be created when a movetables workflow is created (vitessio#13858) Signed-off-by: Rohit Nayak <[email protected]>

…ules should not be created when a movetables workflow is created" (vitessio#13899) Signed-off-by: Rohit Nayak <[email protected]>

… migrations (vitessio#13928) (vitessio#13936) Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Shlomi Noach <[email protected]>

…essio#13921) Co-authored-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

Co-authored-by: frouioui <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>

Signed-off-by: Patrick Carnahan <[email protected]> Signed-off-by: Arthur Schreiber <[email protected]>

Release 16.0 GitHub #70

Release 16.0 GitHub #70

Commits on Jan 13, 2023

Commits on Jan 15, 2023

Commits on Jan 16, 2023

Commits on Jan 17, 2023

Commits on Jan 18, 2023

Commits on Jan 19, 2023

Commits on Jan 20, 2023

Commits on Jan 23, 2023

Commits on Jan 24, 2023

Commits on Jan 25, 2023

Commits on Jan 26, 2023

Commits on Jan 27, 2023

Commits on Jan 29, 2023

Commits on Jan 30, 2023

Commits on Jan 31, 2023

Commits on Feb 1, 2023

Commits on Feb 2, 2023

Commits on Feb 3, 2023

Commits on Feb 8, 2023

Commits on Feb 9, 2023

Commits on Feb 13, 2023

Commits on Feb 15, 2023

Commits on Feb 16, 2023

Commits on Feb 17, 2023

Commits on Feb 21, 2023

Commits on Feb 22, 2023

Commits on Feb 23, 2023

Commits on Feb 24, 2023

Commits on Feb 25, 2023

Commits on Feb 27, 2023

Commits on Feb 28, 2023

Commits on Mar 1, 2023

Commits on Mar 2, 2023

Commits on Mar 7, 2023

Commits on Mar 8, 2023

Commits on Mar 9, 2023

Commits on Mar 13, 2023

Commits on Mar 16, 2023

Commits on Mar 21, 2023

Commits on Mar 22, 2023

Commits on Mar 23, 2023

Commits on Mar 24, 2023

Commits on Mar 27, 2023

Commits on Mar 28, 2023

Commits on Mar 29, 2023

Commits on Mar 30, 2023

Commits on Mar 31, 2023

Commits on Apr 3, 2023

Commits on Apr 4, 2023

Commits on Apr 5, 2023

Commits on Apr 7, 2023

Commits on Apr 10, 2023

Commits on Apr 11, 2023

Commits on Apr 12, 2023

Commits on Apr 14, 2023

Commits on Apr 17, 2023

Commits on Apr 18, 2023

Commits on Apr 24, 2023

Commits on Apr 26, 2023

Commits on May 2, 2023

Commits on May 9, 2023

Commits on May 10, 2023

Commits on May 15, 2023

Commits on May 16, 2023

Commits on May 26, 2023

Commits on May 30, 2023

Commits on May 31, 2023

Commits on Jun 5, 2023

Commits on Jun 7, 2023

Commits on Jun 12, 2023

Commits on Jun 20, 2023

Commits on Jun 22, 2023

Commits on Jun 28, 2023

Commits on Jun 29, 2023

Commits on Jul 5, 2023

Commits on Jul 7, 2023

Commits on Jul 10, 2023

Commits on Jul 11, 2023