-
Notifications
You must be signed in to change notification settings - Fork 60k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update creating-a-github-pages-site-with-jekyll.md #35092
Conversation
The `jekyll new --skip-bundle .` step should happen in the root directory. The previous step said to `cd docs` but seems that's not necessary? But if you're still in the docs directory (from the previous step), you'll create the site in the wrong place. Alternatively, remove the `cd docs` command if it's really not needed.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@textractor Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
@textractor Thanks so much for opening your patience while our SME team reviewed! They've approved your changes ✨ I'll update the branch and get this merged once tests are passing 🍏 If you're looking for an issue to pick up, take a look at our help wanted section to find open issues you can work on ✨ |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
The
jekyll new --skip-bundle .
step should happen in the root directory. The previous step said tocd docs
but seems that's not necessary? But if you're still in the docs directory (from the previous step), you'll create the site in the wrong place.Alternatively, remove the
cd docs
command if it's really not needed.Why: To ensure that a command is run in the right directory
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
A step is being made clearer.
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.