Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable Global Git Hooks in Simple Git #131

Merged

Conversation

riley-kohler
Copy link
Contributor

@riley-kohler riley-kohler commented May 23, 2024

Pull Request

Proposed Changes

Adds a config option to Simple Git which disables the running of global git hooks which may be triggered when running ICF locally. In some testing of the app, unrelated git hooks on my machine caused failures in the app which can be avoided using this flag.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run npm run lint and fix any linting issues that have been introduced
  • run npm run test and run tests

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

@riley-kohler riley-kohler requested a review from a team as a code owner May 23, 2024 18:55
@github-actions github-actions bot added the fix label May 23, 2024
Copy link
Contributor

@ajhenry ajhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ajhenry ajhenry merged commit 2abd2bc into github-community-projects:main May 23, 2024
10 checks passed
@riley-kohler riley-kohler deleted the disable-global-git-hooks branch May 23, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants