feat: swap out smee with homegrown proxy client #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajhenry
changed the title
ajhenry
changed the title
|
Should this also be removed now? Looks like a dead code path if your not using smee any longer: probot-forwarder.js |
zkoppert
reviewed
May 21, 2024
|
@zkoppert Ah yea I was debating leaving the smee client in there in case there's a bug with this one but I now realize that's why we have version control 😄 |
|
Pulled changes and tested locally. Works as expected. |
sutterj
reviewed
May 21, 2024
sutterj
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
This gets rid of smee as the preferred local webhook client. This does not require a webhook url anymore in the env but does require setting
PUBLIC_ORGThis fixes #100
Readiness Checklist
Author/Contributor
npm run lintand fix any linting issues that have been introducednpm run testand run testsReviewer
bug,documentation,enhancement,infrastructure,maintenance, orbreaking