-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UI overhaul #119
Merged
Merged
feat: UI overhaul #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove parent orgs route since we only have one org - Remove orgs page as well
- refactor project to use the newer app router - rework nextauth and trpc for new router
- add header with org for all child pages - move reused hooks into functions
- remove config as bodyParser is not needed with the app router
- Errors were caused by probot middleware being in the app router api - Moved webhooks back to pages router and disabled auth middleware for webhooks
- Add query to edit repo name - Update packages to latest (except octokit) - Add and move dialogs to folders - Add and move flashes to folders - Add breadcrumbs
- There should be a way to do this with jest/ts-jest config - Not working so reverting for now
- Temp fix
- Currently error is null - Ideally would get error message back to include in flash
- Dedupe flashes and loading - Move hooks to folder - Pagination on larger set - Wrap log messages in object - Add comments
Operations I've tried:
things i noticed
Overall this is super awesome work and a huuuuuuge uplift for the app overall!! |
(none of my comments above should be considered a blocker for merging this BTW, all follow-up ideas) |
- make session expire after user is idle for 12 hours - default was 30 days
This reverts commit 1bd76ba.
BREAKING CHANGE: requires converted private key in .env
…nternal-contribution-forks into sutterj/ui-overhaul
ajhenry
reviewed
May 22, 2024
Couple nits that I will make follow-up issues for but I ran through the app and all the functionality works and looks a m a z i n g 👍 🚀 |
ajhenry
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
/src/pages
to/src/app
/src/app/layout.tsx
) to appear on all pages/src/middleware.ts
)/src/app/auth
)/src/app/api/auth/lib/nextauth-options.ts
)/src/app/[organizationId]/layout.tsx
)/src/app
)Readiness Checklist
Author/Contributor
npm run lint
and fix any linting issues that have been introducednpm run test
and run testsReviewer
bug
,documentation
,enhancement
,infrastructure
,maintenance
, orbreaking