Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup the private mirror if it fails to create #109

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

ajhenry
Copy link
Contributor

@ajhenry ajhenry commented Apr 30, 2024

Pull Request

Since switching to a dual tenant model, we need to be explicit about which repo we want to delete on mirror creation failures. This fixes that.

Proposed Changes

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run npm run lint and fix any linting issues that have been introduced
  • run npm run test and run tests

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

@ajhenry ajhenry requested a review from a team as a code owner April 30, 2024 18:34
@ajhenry ajhenry added the fix label Apr 30, 2024
Copy link
Contributor

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Were you able to do any manual testing or should automated testing be added to cover this case?

@ajhenry
Copy link
Contributor Author

ajhenry commented Apr 30, 2024

@zkoppert automated testing will now cover this 😄 we originally only checked to make sure the cleanup function was called but now we explicitly check for argument values for both single and dual org modes

@ajhenry ajhenry merged commit 15c431e into main Apr 30, 2024
13 checks passed
@jmeridth jmeridth deleted the ajhenry/fix-mirror-cleanup branch May 6, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants